Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing json tags #1501

Merged
merged 1 commit into from Jul 2, 2019

Conversation

lionelvillard
Copy link
Member

Proposed Changes

  • add json tags to sequence status.

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jul 2, 2019
@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 2, 2019
@knative-prow-robot
Copy link
Contributor

Hi @lionelvillard. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 2, 2019
@n3wscott
Copy link
Contributor

n3wscott commented Jul 2, 2019

/ok-to-test
/lgtm
/approve

@knative-prow-robot knative-prow-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. lgtm Indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 2, 2019
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lionelvillard, n3wscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 2, 2019
@lionelvillard
Copy link
Member Author

@n3wscott looks like the unit tests are flaky. Can you /retest?

@n3wscott
Copy link
Contributor

n3wscott commented Jul 2, 2019

/retest

@lionelvillard
Copy link
Member Author

it failed on a different test. Annoying.

@chizhg
Copy link
Member

chizhg commented Jul 2, 2019

/retest

@knative-prow-robot knative-prow-robot merged commit e59288e into knative:master Jul 2, 2019
lberk pushed a commit to lberk/eventing that referenced this pull request Jul 15, 2019
@lionelvillard lionelvillard deleted the fixsequencestatus branch January 20, 2020 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants