Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the eventing to the newer opencensus #1532

Merged
merged 3 commits into from Jul 13, 2019
Merged

Update the eventing to the newer opencensus #1532

merged 3 commits into from Jul 13, 2019

Conversation

vagababov
Copy link
Contributor

This is companion change for the knative/pkg#526

/assign @mattmoor @evankanderson @grantr

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jul 12, 2019
@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 12, 2019
@vagababov vagababov mentioned this pull request Jul 12, 2019
Merged
@vagababov
Copy link
Contributor Author

/retest

@knative-prow-robot knative-prow-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 12, 2019
@vagababov
Copy link
Contributor Author

For some reason opencensus-go is not being pulled in at the latest version.

evankanderson
evankanderson reviewed Jul 13, 2019
View reviewed changes
Copy link
Member

@evankanderson evankanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 13, 2019
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: evankanderson, vagababov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 13, 2019
@knative-prow-robot knative-prow-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 13, 2019
@vagababov
Copy link
Contributor Author

I got it compile and pass unit-tests locally!
😿

@mattmoor
Copy link
Member

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 13, 2019
@knative-prow-robot knative-prow-robot merged commit 1bfb346 into knative:master Jul 13, 2019
matzew added a commit to matzew/eventing that referenced this pull request Dec 8, 2021
@openshift-cherrypick-robot @matzew
clap: update to 1.19 product build (knative#1532)
b77d4d7 
Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

Co-authored-by: Matthias Wessendorf <mwessend@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evankanderson evankanderson evankanderson left review comments

@Harwayne Harwayne Awaiting requested review from Harwayne

@vaikas vaikas Awaiting requested review from vaikas

Assignees

@grantr grantr

@mattmoor mattmoor

@evankanderson evankanderson

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@vagababov @knative-prow-robot @mattmoor @evankanderson @grantr @googlebot