New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding webhook details to eventtypes CRD #3063
Conversation
Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
/assign @grantr |
Do we need to also update the webhook conversion code? |
I do not think so, @grantr I did apply:
and I got:
or
and this:
|
Please note, I have no broker I just tried the conversion here on a fresh cluster |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: grantr, matzew The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Matthias Wessendorf mwessend@redhat.com
Fixes #2999
Proposed Changes
Got now:
Release Note
Docs