Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove flows v1alpha1 api #3264

Merged
merged 2 commits into from Jun 4, 2020
Merged

remove flows v1alpha1 api #3264

merged 2 commits into from Jun 4, 2020

Conversation

vaikas
Copy link
Contributor

@vaikas vaikas commented Jun 3, 2020

Fixes #

Proposed Changes

  • Remove flows.v1alpha1 API

Release Note

- 🗑️ Remove feature or internal logic
action required: flows.v1alpha1 is deleted, you must migrate to flows.v1beta1.

Docs
knative/docs#2545

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jun 3, 2020
@knative-prow-robot knative-prow-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 3, 2020
@knative-prow-robot knative-prow-robot added the area/test-and-release Test infrastructure, tests or release label Jun 3, 2020
@vaikas vaikas mentioned this pull request Jun 3, 2020
Closed
@knative-test-reporter-robot
Copy link

The following jobs failed:

Test name Triggers Retries
pull-knative-eventing-integration-tests 0/3
pull-knative-eventing-upgrade-tests 0/3

Failed non-flaky tests preventing automatic retry of pull-knative-eventing-integration-tests:

test/e2e.[build failed]

@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/subscription/subscription.go 85.4% 85.3% -0.1

matzew
matzew approved these changes Jun 4, 2020
View reviewed changes
Copy link
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 4, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, vaikas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 1f1cd6e into knative:master Jun 4, 2020
@vaikas vaikas deleted the remove-flows-v1alpha1 branch June 4, 2020 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matzew matzew matzew approved these changes

@chaodaiG chaodaiG Awaiting requested review from chaodaiG

@lionelvillard lionelvillard Awaiting requested review from lionelvillard

@yt3liu yt3liu Awaiting requested review from yt3liu

Assignees

@matzew matzew

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@vaikas @knative-test-reporter-robot @knative-metrics-robot @knative-prow-robot @matzew @googlebot