Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

receive adapters can now run in leader elected mode #3370

Merged
merged 1 commit into from Jun 24, 2020

Conversation

lionelvillard
Copy link
Member

For #3157

Proposed Changes

  • Receive adapter can now run in leader elected mode

Release Note


Docs

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jun 22, 2020
@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 22, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lionelvillard

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 22, 2020
@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/adapter/v2/config.go 70.8% 64.5% -6.3
pkg/adapter/v2/main.go 61.0% 63.3% 2.3
pkg/adapter/v2/main_message.go 55.3% 58.7% 3.4

@cr22rc
Copy link
Contributor

cr22rc commented Jun 24, 2020

/lgtm

@knative-prow-robot
Copy link
Contributor

@cr22rc: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@aslom
Copy link
Member

aslom commented Jun 24, 2020

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 24, 2020
@knative-prow-robot knative-prow-robot merged commit 84f0958 into knative:master Jun 24, 2020
lberk pushed a commit to lberk/eventing that referenced this pull request Jun 26, 2020
@lionelvillard lionelvillard deleted the leader_adapter branch September 3, 2020 15:32
@lionelvillard lionelvillard restored the leader_adapter branch September 3, 2020 15:41
@lionelvillard lionelvillard deleted the leader_adapter branch September 3, 2020 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants