New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve performance of eventfilter lookups #5288
Conversation
Only do event field lookups as needed, don't pre-emptively cache them into a map
Am I reading those numbers right? this is a 10x improvement? |
The following is the coverage report on the affected files.
|
Codecov Report
@@ Coverage Diff @@
## main #5288 +/- ##
==========================================
+ Coverage 83.63% 83.65% +0.02%
==========================================
Files 243 243
Lines 6879 6891 +12
==========================================
+ Hits 5753 5765 +12
Misses 783 783
Partials 343 343
Continue to review full report at Codecov.
|
Avoiding unnecessary function calls and using a |
/test pull-knative-eventing-go-coverage |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/LGTM
Amazing finding!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking care of that so fast!!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: antoineco, n3wscott The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Only do event field lookups as needed, don't pre-emptively cache them into a map
Fixes #5277
Previous:
Now:
Release Note