Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PingSource stored version is now v1 #5381

Merged
merged 2 commits into from May 18, 2021

Conversation

lionelvillard
Copy link
Member

@lionelvillard lionelvillard commented May 11, 2021

Proposed Changes

  • 🧹 Change PingSource stored version from v1beta2 to v1
  • 🎁 Add post-install job to migrate existing PingSource objects to v1beta2
  • 🗑️ Remove 0.22 Post-install job

Pre-review Checklist

  • At least 80% unit test coverage
  • E2E tests for any new behavior
  • Docs PR for any user-facing impact
  • Spec PR for any new API feature
  • Conformance test for any change to the spec

Release Note

Action Required: You need to run the storage migration tool after the upgrade to migrate from v1beta2 to v1 `pingsources.sources.knative.dev` resources.

Docs

@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label May 11, 2021
@knative-prow-robot knative-prow-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label May 11, 2021
@codecov
Copy link

codecov bot commented May 11, 2021

Codecov Report

Merging #5381 (2670aad) into main (6893451) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5381      +/-   ##
==========================================
- Coverage   82.65%   82.61%   -0.05%     
==========================================
  Files         194      194              
  Lines        6002     6004       +2     
==========================================
- Hits         4961     4960       -1     
- Misses        717      720       +3     
  Partials      324      324              
Impacted Files Coverage Δ
pkg/adapter/mtping/adapter.go 68.88% <ø> (ø)
pkg/adapter/mtping/controller.go 70.58% <ø> (ø)
pkg/reconciler/pingsource/controller.go 86.20% <ø> (ø)
pkg/adapter/mtping/pingsource.go 38.46% <100.00%> (ø)
pkg/adapter/mtping/runner.go 83.33% <100.00%> (ø)
pkg/reconciler/pingsource/pingsource.go 80.95% <100.00%> (ø)
pkg/apis/flows/v1/sequence_lifecycle.go 91.80% <0.00%> (-4.81%) ⬇️
pkg/apis/flows/v1/sequence_types.go 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6893451...2670aad. Read the comment docs.

@knative-prow-robot knative-prow-robot added the area/test-and-release Test infrastructure, tests or release label May 11, 2021
@lionelvillard
Copy link
Member Author

/hold

let's merge this one after 0.23 is released so that we don't have to deal with downgrade issues.

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 11, 2021
@lionelvillard
Copy link
Member Author

0.23 is out.

/unhold

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 18, 2021
@lionelvillard
Copy link
Member Author

/test pull-knative-eventing-upgrade-tests

Copy link
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label May 18, 2021
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 18, 2021
@lionelvillard
Copy link
Member Author

/test pull-knative-eventing-conformance-tests

@knative-prow-robot knative-prow-robot merged commit 62a75eb into knative:main May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants