-
Notifications
You must be signed in to change notification settings - Fork 586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename Sinkable to Addressable. #583
Rename Sinkable to Addressable. #583
Conversation
lgtm I want a second review, so I will let someone else let it commit. |
@@ -167,17 +167,17 @@ func (r *reconciler) updateStatus(subscription *v1alpha1.Subscription) (*v1alpha | |||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this file has one more reference to Targetable
:
return fmt.Errorf("could not get domain from subscriber (is it not targetable?)") |
@@ -54,7 +54,7 @@ const ( | |||
testNS = "testnamespace" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this, and references be changed too?
sinkableDNS = "myresultchannel.mynamespace.svc.cluster.local" |
/lgtm added some minor comments |
I think we also need to update the eventing-sources repo for the sources in there? |
Did you run through the samples to see if they still work after this change? |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: evankanderson, vaikas-google The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Temporarily use Addressable for Callable as well.
Fixes #542
Proposed Changes
I also re-wrapped a few lines that were folded just over 80 chars while I was fixing comments. Sorry!
Release Note