Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix performance tests setup #6340

Merged
merged 5 commits into from
Apr 27, 2022

Conversation

gabo1208
Copy link
Member

@gabo1208 gabo1208 commented Apr 19, 2022

Fixes #6339

Proposed Changes

  • 🐛 Fixes wrong value being used on the Sender Throughput graph (the latency values were being used)
  • 🎁 Added right graphs to the plot plg file, included the latency and correct throughput values
  • 🧹 Fixed Api versions on yamls (they were pointing to beta and alpha versions not included anymore on the releases)

Pre-review Checklist

  • At least 80% unit test coverage
  • E2E tests for any new behavior
  • Docs PR for any user-facing impact
  • Spec PR for any new API feature
  • Conformance test for any change to the spec

Release Note

Now the Eventing Performance tests are ready to use, including Sender Throughput  and latency graphs 

…n yaml files + added some details to the Readme and fixed .plg graph values
@knative-prow knative-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/test-and-release Test infrastructure, tests or release labels Apr 19, 2022
@codecov
Copy link

codecov bot commented Apr 19, 2022

Codecov Report

Merging #6340 (a5c66d2) into main (5ede92d) will increase coverage by 0.20%.
The diff coverage is 58.13%.

@@            Coverage Diff             @@
##             main    #6340      +/-   ##
==========================================
+ Coverage   82.18%   82.39%   +0.20%     
==========================================
  Files         231      233       +2     
  Lines        7787    11565    +3778     
==========================================
+ Hits         6400     9529    +3129     
- Misses        937     1573     +636     
- Partials      450      463      +13     
Impacted Files Coverage Δ
pkg/apis/sugar/store.go 12.50% <12.50%> (ø)
pkg/reconciler/sugar/namespace/namespace.go 68.96% <72.72%> (-4.37%) ⬇️
pkg/reconciler/sugar/trigger/trigger.go 68.96% <75.00%> (-2.47%) ⬇️
pkg/apis/sugar/sugar.go 90.47% <90.47%> (ø)
pkg/reconciler/sugar/namespace/controller.go 84.61% <100.00%> (+5.44%) ⬆️
pkg/reconciler/sugar/trigger/controller.go 62.79% <100.00%> (+7.23%) ⬆️
pkg/apis/flows/v1/register.go 69.23% <0.00%> (-10.77%) ⬇️
pkg/apis/eventing/v1/register.go 69.23% <0.00%> (-10.77%) ⬇️
pkg/apis/messaging/v1/register.go 73.33% <0.00%> (-10.00%) ⬇️
pkg/adapter/apiserver/filter.go 62.50% <0.00%> (-5.93%) ⬇️
... and 227 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e874b89...a5c66d2. Read the comment docs.

@gabo1208
Copy link
Member Author

/retest

@pierDipi
Copy link
Member

/approve
/cc @salaboy @gab-satchi

@knative-prow
Copy link

knative-prow bot commented Apr 27, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gabo1208, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 27, 2022
@salaboy
Copy link
Member

salaboy commented Apr 27, 2022

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Apr 27, 2022
@gabo1208
Copy link
Member Author

/retest

@lionelvillard
Copy link
Member

/retest-required

@knative-prow knative-prow bot merged commit 2219e14 into knative:main Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix performance tests graph values and yamls
4 participants