Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly initialize branchStatuses #6354

Merged
merged 1 commit into from
Apr 27, 2022
Merged

Conversation

lionelvillard
Copy link
Member

Fixes #6353

Proposed Changes

  • 馃悰 Fix Parallel not properly updating the status section when the underlying Channel failed to be created

Pre-review Checklist

  • At least 80% unit test coverage
  • E2E tests for any new behavior
  • Docs PR for any user-facing impact
  • Spec PR for any new API feature
  • Conformance test for any change to the spec

Release Note

Fix Parallel not properly reporting underlying Channel creation failures

Docs

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 26, 2022
@codecov
Copy link

codecov bot commented Apr 26, 2022

Codecov Report

Merging #6354 (b4f6370) into main (3e24a78) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #6354   +/-   ##
=======================================
  Coverage   82.39%   82.39%           
=======================================
  Files         233      233           
  Lines       11565    11567    +2     
=======================================
+ Hits         9529     9531    +2     
  Misses       1573     1573           
  Partials      463      463           
Impacted Files Coverage 螖
pkg/reconciler/parallel/parallel.go 62.50% <100.00%> (+0.33%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 3e24a78...b4f6370. Read the comment docs.

Copy link
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Apr 27, 2022
@knative-prow
Copy link

knative-prow bot commented Apr 27, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lionelvillard, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [lionelvillard,matzew]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@matzew
Copy link
Member

matzew commented Apr 27, 2022

/test upgrade-tests_eventing_main

@knative-prow knative-prow bot merged commit 3abb436 into knative:main Apr 27, 2022
@lionelvillard
Copy link
Member Author

/cherry-pick release-1.4

@knative-prow-robot
Copy link
Contributor

@lionelvillard: new pull request created: #6362

In response to this:

/cherry-pick release-1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid value in the status section.
3 participants