Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pingsource-mt-adapter crash when initial replica is more than 0 #6359

Merged
merged 1 commit into from
Apr 28, 2022

Conversation

lionelvillard
Copy link
Member

Proposed Changes

  • 馃悰 Fix pingsource-mt-adapter crash when initial replica is more than 0

Pre-review Checklist

  • At least 80% unit test coverage
  • E2E tests for any new behavior
  • Docs PR for any user-facing impact
  • Spec PR for any new API feature
  • Conformance test for any change to the spec

Release Note

:bug: Fix pingsource-mt-adapter crash when the initial replicas is set to a value other than 0

Docs

@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 28, 2022
@knative-prow
Copy link

knative-prow bot commented Apr 28, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lionelvillard

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 28, 2022
@cr22rc
Copy link
Contributor

cr22rc commented Apr 28, 2022

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Apr 28, 2022
@codecov
Copy link

codecov bot commented Apr 28, 2022

Codecov Report

Merging #6359 (a030db5) into main (11dd387) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #6359   +/-   ##
=======================================
  Coverage   82.39%   82.39%           
=======================================
  Files         233      233           
  Lines       11567    11567           
=======================================
  Hits         9531     9531           
  Misses       1573     1573           
  Partials      463      463           

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 11dd387...a030db5. Read the comment docs.

@knative-prow knative-prow bot merged commit 01f5612 into knative:main Apr 28, 2022
@lionelvillard
Copy link
Member Author

/cherry-pick release-1.4

@knative-prow-robot
Copy link
Contributor

@lionelvillard: new pull request created: #6361

In response to this:

/cherry-pick release-1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants