APIServerSource with selector to target namespaces

[gab-satchi]

Fixes #6644

Proposed Changes

• 🎁 ApiServerSource can specify a selector to target one or more namespaces. If the selector is missing, it will default to targeting the namespace in which the source resides

API changes (additive):

• spec.namespaceSelector: A label selector to identify namespaces to track
• status.namespaces: A list of namespaces currently being tracked by the source

Pre-review Checklist

• At least 80% unit test coverage
• E2E tests for any new behavior
• Docs PR for any user-facing impact
• Spec PR for any new API feature
• Conformance test for any change to the spec

Release Note

📄 ApiServerSource can specify a selector to target one or more namespaces. If the selector is missing, it will default to targeting the namespace in which the source resides

Docs

Docs to follow once the behaviour is finalized and approved.

[codecov]

Codecov Report

Base: 80.62% // Head: 80.49% // Decreases project coverage by -0.14% ⚠️

Coverage data is based on head (2775d57) compared to base (466d123).
Patch coverage: 80.58% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6665      +/-   ##
==========================================
- Coverage   80.62%   80.49%   -0.14%     
==========================================
  Files         236      236              
  Lines       12018    12071      +53     
==========================================
+ Hits         9690     9717      +27     
- Misses       1847     1867      +20     
- Partials      481      487       +6     

Impacted Files	Coverage Δ
pkg/apis/sources/v1/apiserver_types.go	100.00% <ø> (ø)
pkg/reconciler/apiserversource/controller.go	74.35% <46.15%> (-15.30%)	⬇️
pkg/reconciler/apiserversource/apiserversource.go	80.75% <82.43%> (-1.44%)	⬇️
pkg/adapter/apiserver/adapter.go	68.18% <100.00%> (+1.12%)	⬆️
...ciler/apiserversource/resources/receive_adapter.go	92.24% <100.00%> (+0.06%)	⬆️
pkg/broker/filter/filter_handler.go	75.51% <0.00%> (-2.63%)	⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[pierDipi]

Can we add an E2E tests with rekt?

[gab-satchi]

Thanks for the review @pierDipi, I've addressed the comments. Working on adding an e2e test now

[evankanderson]

Question: do we want to do per-namespace watches, or do we want to leverage an all-namespace watch (different path, single watch rather than one call per namespace)?

[gab-satchi]

An all namespaces watch is useful. I can simplify the namespaces in the status to just say ALL as well for readability. The authorization check would still need to be per namespace I believe.

I left the status as is. It provides more information than just saying ALL

[gab-satchi]

/retest

[gab-satchi]

/hold until the reconciler-test changes come in

[evankanderson]

/retest

[evankanderson]

@gab-satchi
Do we expect reconciler-test changes to have come in and fixed the problem? If not, we'll need to re-cut the reconciler-test branch with another cherrypick...

/retest

Though I doubt it will help.

[gab-satchi]

/hold cancel

changes from reconciler-test have been merged

[evankanderson]

/retest

[evankanderson]

(it looks like ./test/experimental/... and ./test/rekt/... may be failing for cause (I attempted a re-run)

[pierDipi]

/lgtm
/approve

[knative-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gab-satchi, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [pierDipi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[matzew]

Unit Test (eventing-kafka-broker, knative-sandbox) was broken by this (see in the GA actions)

[gab-satchi]

I did a rebase once the reconciler-test changes were in. Before that, I believe the unit tests were passing like in this run

I'm also seeing the same failure with these changes

I'll look into it some more but my familiarity with kafka is pretty limited.

[pierDipi]

eventing kafka broker is fixed but it wasn't related to this PR