-
Notifications
You must be signed in to change notification settings - Fork 575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds apiVersion as an extension to api source events #6696
Conversation
Codecov ReportBase: 80.53% // Head: 80.53% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #6696 +/- ##
=======================================
Coverage 80.53% 80.53%
=======================================
Files 236 236
Lines 12100 12101 +1
=======================================
+ Hits 9745 9746 +1
Misses 1867 1867
Partials 488 488
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we cover this with an e2e test?
0c6125c
to
ee1f08c
Compare
Failures aren't related to the e2e test this PR changes /retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gab-satchi, gabo1208, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
Pre-review Checklist
Release Note
Kind alone isn't always unique. With the fully qualified gvk, filtering at the Trigger will be more consistent. I left Kind as a separate extension instead of bringing everything under a
gvk
extension to maintain backwards compatibility.