Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds apiVersion as an extension to api source events #6696

Merged
merged 2 commits into from
Feb 9, 2023

Conversation

gab-satchi
Copy link
Contributor

@gab-satchi gab-satchi commented Jan 20, 2023

  • 🎁 Adds apiVersion as an extension to APIServerSource events

Pre-review Checklist

  • At least 80% unit test coverage
  • E2E tests for any new behavior
  • Docs PR for any user-facing impact
  • Spec PR for any new API feature
  • Conformance test for any change to the spec

Release Note

🎁  APIServerSource events includes apiVersion of the object
// We copy the resource kind, name and namespace as extensions so that triggers can do the filter based on these attributes

Kind alone isn't always unique. With the fully qualified gvk, filtering at the Trigger will be more consistent. I left Kind as a separate extension instead of bringing everything under a gvk extension to maintain backwards compatibility.

@knative-prow knative-prow bot requested review from lberk and pierDipi January 20, 2023 20:04
@knative-prow knative-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 20, 2023
@codecov
Copy link

codecov bot commented Jan 20, 2023

Codecov Report

Base: 80.53% // Head: 80.53% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (ee1f08c) compared to base (8b7551c).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6696   +/-   ##
=======================================
  Coverage   80.53%   80.53%           
=======================================
  Files         236      236           
  Lines       12100    12101    +1     
=======================================
+ Hits         9745     9746    +1     
  Misses       1867     1867           
  Partials      488      488           
Impacted Files Coverage Δ
pkg/adapter/apiserver/events/events.go 94.17% <100.00%> (+0.05%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 24, 2023
@pierDipi
Copy link
Member

pierDipi commented Feb 3, 2023

/retest

Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we cover this with an e2e test?

@knative-prow knative-prow bot added area/test-and-release Test infrastructure, tests or release and removed lgtm Indicates that a PR is ready to be merged. labels Feb 3, 2023
@gab-satchi
Copy link
Contributor Author

Failures aren't related to the e2e test this PR changes

/retest

Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 9, 2023
@knative-prow
Copy link

knative-prow bot commented Feb 9, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gab-satchi, gabo1208, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 9, 2023
@gab-satchi
Copy link
Contributor Author

/retest

@knative-prow knative-prow bot merged commit 452cd49 into knative:main Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants