updated broken link

[keshavcodex]

Fixes #5867

I updated NewConfigFromMap broken link in configmap.go file

[knative-prow]

Welcome @keshavcodex! It looks like this is your first PR to knative/eventing 🎉

[knative-prow]

Hi @keshavcodex. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[keshavcodex]

SinkBinding runtime contract link is broken and i don't where this file has moved, can someone help me?

[pierDipi]

It is here: https://github.com/knative/eventing/blob/main/docs/spec/sources.md#container-runtime-contract

[keshavcodex]

in page ./docs/delivery/README.md these Source Delivery
and Channel Delivery link is broken. Is this the new link for both https://knative.dev/docs/eventing/channels/ ?

[pierDipi]

I would use a single link pointing to https://github.com/knative/specs/blob/main/specs/eventing/data-plane.md#event-delivery

[keshavcodex]

I have updated all the links according to this page, and I hope all links are working perfectly, please let me know if I missed some.

Now, we can close #5867.

[knative-prow]

@keshavcodex: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[pierDipi]

/ok-to-test

[codecov]

Codecov Report

Patch and project coverage have no change.

Comparison is base (1ff36e1) 80.45% compared to head (d5d3974) 80.45%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #6786   +/-   ##
=======================================
  Coverage   80.45%   80.45%           
=======================================
  Files         236      236           
  Lines       12213    12213           
=======================================
  Hits         9826     9826           
  Misses       1896     1896           
  Partials      491      491           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[aliok]

@keshavcodex As we talked in the WG meeting, we use Prow to manage PRs in Knative.

One example where there's a failure with Prow jobs is here: knative-extensions/eventing-kafka-broker#2997 (comment)

This is just an example.

You can see Rerun command column.

All these being said, the failures in this PR is not failing Prow jobs. There are some Github actions that fail. These Github actions are used alongside with Prow.

Current Downstream / Unite Test failures with eventing-autoscaler-keda and etc. are irrelevant to your changes. There is probably a build failure in https://github.com/knative-sandbox/eventing-autoscaler-keda repository, which is also reported here.

[aliok]

/lgtm
/approve

[knative-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aliok, keshavcodex

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [aliok]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment