Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removed release label #6807

Merged
merged 2 commits into from
Mar 28, 2023
Merged

removed release label #6807

merged 2 commits into from
Mar 28, 2023

Conversation

Abhishek357
Copy link
Contributor

Fixes #6383

Proposed Changes

removed release labels.

Release Note

We have app.kubernetes.io/version label that contains release information, so droping release labels.

@knative-prow knative-prow bot added the area/test-and-release Test infrastructure, tests or release label Mar 9, 2023
@knative-prow
Copy link

knative-prow bot commented Mar 9, 2023

Welcome @Abhishek357! It looks like this is your first PR to knative/eventing 🎉

@knative-prow knative-prow bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 9, 2023
@knative-prow
Copy link

knative-prow bot commented Mar 9, 2023

Hi @Abhishek357. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 9, 2023
@matzew
Copy link
Member

matzew commented Mar 9, 2023

serving did it a while ago, see here: knative/serving#12754

@matzew
Copy link
Member

matzew commented Mar 9, 2023

So, we still have files that are reflecting the labels:
https://github.com/Abhishek357/eventing/blob/unused-labels/hack/generate-yamls.sh#L74

So this PR is not yet complete (see the serving one for reference)

@codecov
Copy link

codecov bot commented Mar 9, 2023 •
edited

Codecov Report

Patch and project coverage have no change.

Comparison is base (05f6d84) 80.45% compared to head (4ece1cb) 80.46%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #6807   +/-   ##
=======================================
  Coverage   80.45%   80.46%           
=======================================
  Files         236      236           
  Lines       12213    12237   +24     
=======================================
+ Hits         9826     9846   +20     
- Misses       1896     1899    +3     
- Partials      491      492    +1

see 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@matzew
Copy link
Member

matzew commented Mar 10, 2023

Thanks for the PR @Abhishek357 ! Please see my comment above!

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Mar 10, 2023 •
edited

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: Abhishek357 / name: Abhishek Singh Chauhan (1861041)

@knative-prow knative-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 10, 2023
@Abhishek357
removed release label
1861041 
Signed-off-by: Abhishek357 <abhisheksinghchauhan357@gmail.com>
@Abhishek357
Copy link
Contributor Author

@matzew I have made the chages can you review.

@matzew
Copy link
Member

matzew commented Mar 14, 2023

/ok-to-test

@knative-prow knative-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 14, 2023
@matzew
Copy link
Member

matzew commented Mar 14, 2023

/easy-cla

@matzew
Copy link
Member

matzew commented Mar 14, 2023

@Abhishek357 thanks for the updates, Did you put in your CLA?

@matzew
Copy link
Member

matzew commented Mar 15, 2023

/retest

@Abhishek357
fix e2e-tests
4ece1cb 
Signed-off-by: Abhishek357 <abhisheksinghchauhan357@gmail.com>
@Abhishek357
Copy link
Contributor Author

hey @matzew I have added CLA and fixed the tests as well.

@pierDipi
Copy link
Member

/assign @matzew

@Abhishek357
Copy link
Contributor Author

/retest

matzew
matzew approved these changes Mar 28, 2023
View reviewed changes
Copy link
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Mar 28, 2023
@knative-prow
Copy link

knative-prow bot commented Mar 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Abhishek357, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 28, 2023
@knative-prow knative-prow bot merged commit e691b39 into knative:main Mar 28, 2023
1 check passed
vishal-chdhry pushed a commit to vishal-chdhry/eventing that referenced this pull request Apr 25, 2023
@Abhishek357 @vishal-chdhry
removed release label (knative#6807)
d751007 
Fixes knative#6383

<!-- Please include the 'why' behind your changes if no issue exists -->

## Proposed Changes
removed release labels.
<!-- Please categorize your changes:
- 🎁 Add new feature
- 🐛 Fix bug
- 🧹 Update or clean up current behavior
- 🗑️ Remove feature or internal logic
-->

**Release Note**

<!--
📄 If this change has user-visible impact, write a release
note in the block
below. Include the string "action required" if additional action is
required of
users switching to the new release, for example in case of a breaking
change.

Write as if you are speaking to users, not other Knative contributors.
If this
change has no user-visible impact, no release note is needed.
-->

```release-note
We have app.kubernetes.io/version label that contains release information, so droping release labels.
```

---------

Signed-off-by: Abhishek357 <abhisheksinghchauhan357@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matzew matzew matzew approved these changes

@mgencur mgencur Awaiting requested review from mgencur

@odacremolbap odacremolbap Awaiting requested review from odacremolbap

Assignees

@matzew matzew

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Drop usage of eventing.knative.dev/release
3 participants
@Abhishek357 @matzew @pierDipi