Sync retry option with spec #6834
Conversation
|
|
|
Welcome @Rahul-Kumar-prog! It looks like this is your first PR to knative/eventing 🎉 |
knative-prow
bot
added
needs-ok-to-test
|
Hi @Rahul-Kumar-prog. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| @@ -83,7 +83,7 @@ func RetryConfigFromDeliverySpec(spec v1.DeliverySpec) (RetryConfig, error) { | |||
|
|
|||
| retryConfig := NoRetries() | |||
|
|
|||
| retryConfig.CheckRetry = RetryIfGreaterThan300 | |||
There was a problem hiding this comment.
Is RetryIfGreaterThan300 function used somewhere? Can we remove it?
There was a problem hiding this comment.
sorry I accidentally add the RetryIfGreaterThan300 test screen short
There was a problem hiding this comment.
This is the correct one.
There was a problem hiding this comment.
Ok, if the function RetryIfGreaterThan300 is only used in tests, we should remove it
There was a problem hiding this comment.
The reason being, if the function is not useful to production code, we don't need it anymore and we should remove it
There was a problem hiding this comment.
so I need to remove the RetryIfGreaterThen300 entirely ?
There was a problem hiding this comment.
It depends if it is still used and where in the codebase, have you found the places where the RetryIfGreaterThen300 function is used in your branch?
knative-prow
bot
added
size/L
|
/ok-to-test |
knative-prow
bot
added
ok-to-test
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #6834 +/- ##
=======================================
Coverage 80.45% 80.45%
=======================================
Files 236 236
Lines 12213 12235 +22
=======================================
+ Hits 9826 9844 +18
- Misses 1896 1899 +3
- Partials 491 492 +1
... and 2 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
|
/test upgrade-tests |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pierDipi, Rahul-Kumar-prog The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
bot
added
the
approved
|
/test upgrade-tests |
Fixes knative#6691 ## Proposed Changes change imc dispatcher's retry option form `RetryGreaterThen300` to `SelectiveRetry` ### Pre-review Checklist <!-- If these boxes are not checked, you will be asked to complete these requirements or explain why they do not apply to your PR. --> - [ ] **At least 80% unit test coverage** - [ ] **E2E tests** for any new behavior - [ ] **Docs PR** for any user-facing impact - [ ] **Spec PR** for any new API feature - [ ] **Conformance test** for any change to the spec **Release Note** <!-- :page_facing_up: If this change has user-visible impact, write a release note in the block below. Include the string "action required" if additional action is required of users switching to the new release, for example in case of a breaking change. Write as if you are speaking to users, not other Knative contributors. If this change has no user-visible impact, no release note is needed. --> ```release-note ``` **Docs** <!-- :book: If this change has user-visible impact, link to an issue or PR in https://github.com/knative/docs. --> **Debug Test Image** <img width="1270" alt="Screenshot 2023-04-03 at 4 32 59 PM" src="https://user-images.githubusercontent.com/68837569/229492305-1cd9b042-5794-4268-b403-b97d28bfe7f5.png">
Fixes #6691
Proposed Changes
change imc dispatcher's retry option form
RetryGreaterThen300toSelectiveRetryPre-review Checklist
Release Note
Docs
Debug Test Image