Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imc-dispatcher starts a TLS server, accepts host based routing on http receiver and path based routing on https receiver #6954

Merged
merged 5 commits into from
May 26, 2023

Conversation

gab-satchi
Copy link
Contributor

Fixes #6874

  • Adds TLS role for reading Secrets within the system namespace
  • Dispatcher service and deployment have additional ports for https
  • We create two handlers for each channel: An "http" one that only accepts host based and an "https" one that will only work with path based.

Pre-review Checklist

  • At least 80% unit test coverage
  • E2E tests for any new behavior
  • Docs PR for any user-facing impact
  • Spec PR for any new API feature
  • Conformance test for any change to the spec

Release Note

📄 imc-dispatcher supports an https endpoint for receiving events. The channel is deduced from the path.

Docs

@knative-prow knative-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 17, 2023
@codecov
Copy link

codecov bot commented May 17, 2023

Codecov Report

Patch coverage: 74.28% and project coverage change: -0.08 ⚠️

Comparison is base (fc5befb) 79.81% compared to head (77f7937) 79.73%.

❗ Current head 77f7937 differs from pull request most recent head f48bce0. Consider uploading reports for the commit f48bce0 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6954      +/-   ##
==========================================
- Coverage   79.81%   79.73%   -0.08%     
==========================================
  Files         244      244              
  Lines       12788    12857      +69     
==========================================
+ Hits        10207    10252      +45     
- Misses       2075     2095      +20     
- Partials      506      510       +4     
Impacted Files Coverage Δ
pkg/inmemorychannel/message_dispatcher.go 82.60% <0.00%> (-7.87%) ⬇️
...iler/inmemorychannel/dispatcher/inmemorychannel.go 78.46% <58.62%> (-7.26%) ⬇️
...econciler/inmemorychannel/dispatcher/controller.go 83.63% <80.85%> (-4.83%) ⬇️
...nnelfanout/multi_channel_fanout_message_handler.go 86.88% <83.33%> (+2.57%) ⬆️
pkg/channel/fanout/fanout_message_handler.go 86.74% <100.00%> (ø)
...reconciler/inmemorychannel/dispatcher/readiness.go 72.41% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gab-satchi
Copy link
Contributor Author

/retest

Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 26, 2023
@knative-prow
Copy link

knative-prow bot commented May 26, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gab-satchi, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 26, 2023
@knative-prow knative-prow bot merged commit 59118a0 into knative:main May 26, 2023
30 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Eventing TLS: support creating TLS server for InMemoryChannel dispatcher
2 participants