Updated mtping TLS cert test to bind to free port #7036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow
bot
added
the
size/M
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #7036 +/- ##
=======================================
Coverage 78.59% 78.59%
=======================================
Files 249 249
Lines 13228 13228
=======================================
Hits 10396 10396
Misses 2304 2304
Partials 528 528 ☔ View full report in Codecov by Sentry. |
|
/lgtm |
|
/assign @Cali0707 |
pierDipi
reviewed
Jun 23, 2023
knative-prow
bot
added
size/XS
|
/retest-required |
knative-prow
bot
added
lgtm
knative-prow-robot
added
the
needs-rebase
|
Ah there are conflicts |
Signed-off-by: Calum Murray <cmurray@redhat.com>
knative-prow-robot
removed
the
needs-rebase
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Cali0707, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test upgrade-tests |
|
/retest-required |
|
/retest |
|
/retest-required |
vishal-chdhry
pushed a commit
to vishal-chdhry/eventing
that referenced
this pull request
Jul 6, 2023
Fixes knative#7028 Looking at the logs, it seems like this test fails because it cannot bind to the required port: ``` === FAIL: pkg/adapter/mtping TestSendEventsTLS/Valid_CA_certs (unknown) panic: listen tcp :8334: bind: address already in use goroutine 226 [running]: knative.dev/eventing/pkg/eventingtls/eventingtlstesting.StartServer.func1() /home/prow/go/src/knative.dev/eventing/pkg/eventingtls/eventingtlstesting/eventingtlstesting.go:77 +0x88 created by knative.dev/eventing/pkg/eventingtls/eventingtlstesting.StartServer /home/prow/go/src/knative.dev/eventing/pkg/eventingtls/eventingtlstesting/eventingtlstesting.go:74 +0x7ea ``` <!-- Please include the 'why' behind your changes if no issue exists --> ## Proposed Changes <!-- Please categorize your changes: - 🎁 Add new feature - 🐛 Fix bug - 🧹 Update or clean up current behavior - 🗑️ Remove feature or internal logic --> - Update the test to bind to a free address, using port 0 (https://www.lifewire.com/port-0-in-tcp-and-udp-818145) ### Pre-review Checklist <!-- If these boxes are not checked, you will be asked to complete these requirements or explain why they do not apply to your PR. --> - [ ] **At least 80% unit test coverage** - [ ] **E2E tests** for any new behavior - [ ] **Docs PR** for any user-facing impact - [ ] **Spec PR** for any new API feature - [ ] **Conformance test** for any change to the spec --------- Signed-off-by: Calum Murray <cmurray@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7028
Looking at the logs, it seems like this test fails because it cannot bind to the required port:
Proposed Changes
Pre-review Checklist