Add serviceaccount in parallel

[prakrit55]

Fixes #7225

Proposed Changes

• create the service account for the Parallel identity
• configured the informers and configmap watchers

Pre-review Checklist

• At least 80% unit test coverage
• E2E tests for any new behavior
• Docs PR for any user-facing impact
• Spec PR for any new API feature
• Conformance test for any change to the spec

[knative-prow]

Hi @prakrit55. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[creydr]

Thanks @prakrit55 for your PR. I left some comments. As discussed, could you also add unit tests for this?

[creydr]

Hello @prakrit55,
Thanks for the update. I left a few comments. We mostly need tests for this new behavior.

You can always run and test your changes locally too. Check out the DEVELOPMENT.md with details about how to install it in a local cluster (e.g. KinD or minikube) or how to run the tests.
I hope this helps

[creydr]

Hello @prakrit55,
any updates on this? Do you need any more information?

[prakrit55]

Hey @creydr, I was somewhat busy in past few days, I will make it done in some days.

[creydr]

/ok-to-test

[creydr]

Hello @prakrit55,
I didn't see you updated the tests. Thanks for doing this.
The unit tests are failing currently, as it doesn't know the features-config map. When you pass the configmap to configmap.NewStaticWatcher() in parallel/controller_test.go as done in subscription/controller_test.go, this should do the trick:

c := NewController(ctx, configmap.NewStaticWatcher(
	&corev1.ConfigMap{
		ObjectMeta: metav1.ObjectMeta{
			Name: feature.FlagsConfigName,
		},
	},
))

And can you fix the lint issues? You can see them, on the files overview of this PR. (you can simply run gofmt -s -w ./pkg and gofmt -s -w ./test to fix them)

[prakrit55]

hey @creydr, I fixed the lint, could you check it once

[prakrit55]

/retest

[creydr]

@prakrit55 thanks for checking on the linter issues.
Some unit test see still to fail. Can you check on them? You can also run them locally by go test ./pkg/...

[codecov]

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (0684dbe) 76.74% compared to head (dc92aa1) 76.76%.
Report is 20 commits behind head on main.

Files	Patch %	Lines
pkg/reconciler/parallel/controller.go	81.48%	3 Missing and 2 partials ⚠️
pkg/apis/flows/v1/parallel_lifecycle.go	50.00%	4 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7373      +/-   ##
==========================================
+ Coverage   76.74%   76.76%   +0.01%     
==========================================
  Files         253      253              
  Lines       13916    14019     +103     
==========================================
+ Hits        10680    10761      +81     
- Misses       2702     2720      +18     
- Partials      534      538       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[creydr]

Thanks for doing this @prakrit55 👍

/lgtm

[knative-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, prakrit55

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [creydr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[prakrit55]

Thanks for doing this @prakrit55 👍

/lgtm

sorry for the delay 😅