Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable the TLS feature for ContainerSource's OIDC tests #7559

Closed

Conversation

Leo6Leo
Copy link
Member

@Leo6Leo Leo6Leo commented Jan 9, 2024

Fixes #7558

Proposed Changes

  • EventsHub receiver/sender with enforced TLS and individual resources which deliver events with CACerts specified for Destination

Pre-review Checklist

  • At least 80% unit test coverage
  • E2E tests for any new behavior
  • Docs PR for any user-facing impact
  • Spec PR for any new API feature
  • Conformance test for any change to the spec

Release Note


Docs

Copy link

knative-prow bot commented Jan 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Leo6Leo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 9, 2024
@knative-prow knative-prow bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/test-and-release Test infrastructure, tests or release labels Jan 9, 2024
Copy link

codecov bot commented Jan 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (36b3115) 75.57% compared to head (268837f) 75.57%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7559   +/-   ##
=======================================
  Coverage   75.57%   75.57%           
=======================================
  Files         261      261           
  Lines       14668    14669    +1     
=======================================
+ Hits        11085    11086    +1     
  Misses       3004     3004           
  Partials      579      579           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Leo6Leo
Copy link
Member Author

Leo6Leo commented Jan 10, 2024

/cc @Cali0707 @creydr

Copy link
Member

@creydr creydr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Leo6Leo for working on this.
Anyhow I guess we have the same as for #7551 and #7556 here and I don't think those tests are run in CI, as you have f.Prerequisite("transport encryption is strict", featureflags.TransportEncryptionStrict()) and we don't have set the feature flag accordingly. See #7556 (review)

@Leo6Leo
Copy link
Member Author

Leo6Leo commented Jan 18, 2024

Close this PR as it has been completed in #7551

@Leo6Leo Leo6Leo closed this Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable TLS for ContainerSource's OIDC tests
2 participants