New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: brokers can be added to event lineage graph #7731
Conversation
Signed-off-by: Calum Murray <cmurray@redhat.com>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Cali0707 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7731 +/- ##
==========================================
+ Coverage 69.04% 69.11% +0.06%
==========================================
Files 338 339 +1
Lines 19350 19398 +48
==========================================
+ Hits 13360 13406 +46
- Misses 5328 5330 +2
Partials 662 662 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good to me! just left few questions
@@ -0,0 +1,159 @@ | |||
/* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
go imports problem
Signed-off-by: Calum Murray <cmurray@redhat.com>
/lgtm |
Fixes #7681
Proposed Changes
Pre-review Checklist
Release Note
Docs