Reconcile trigger on OIDC service account changes only, if SA references a trigger for correct broker class

[creydr]

Currently we reconcile Triggers when a OIDC service account changes. This is also done, when the OIDC service account is from a Trigger for a different broker class.
This PR addresses it and adds a filter function to reconcile Triggers on OIDC SA changes only, if the SA is owned by a Trigger for the MTChannelBasedBroker broker class.

[codecov]

Codecov Report

Attention: Patch coverage is 62.50000% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 69.54%. Comparing base (7e1c082) to head (0c25216).
Report is 18 commits behind head on main.

Files	Patch %	Lines
pkg/reconciler/broker/trigger/controller.go	62.50%	3 Missing and 3 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7849      +/-   ##
==========================================
+ Coverage   69.22%   69.54%   +0.32%     
==========================================
  Files         339      340       +1     
  Lines       19494    15741    -3753     
==========================================
- Hits        13494    10947    -2547     
+ Misses       5337     4124    -1213     
- Partials      663      670       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[creydr]

/test reconciler-tests

[creydr]

/test reconciler-tests

[creydr]

seems CI is having a bad day:
the server is currently unable to handle the request

/test reconciler-tests

[creydr]

/retest-required

[pierDipi]

/lgtm
/approve

[knative-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [creydr,pierDipi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[creydr]

/test reconciler-tests

[creydr]

/cherry-pick release-1.13

[knative-prow-robot]

@creydr: once the present PR merges, I will cherry-pick it on top of release-1.13 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[knative-prow-robot]

@creydr: #7849 failed to apply on top of branch "release-1.13":

Applying: Reconcile trigger on OIDC service account changes only, if SA references a trigger for correct broker class
Using index info to reconstruct a base tree...
M	pkg/reconciler/broker/trigger/controller.go
M	pkg/reconciler/broker/trigger/controller_test.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/reconciler/broker/trigger/controller_test.go
CONFLICT (content): Merge conflict in pkg/reconciler/broker/trigger/controller_test.go
Auto-merging pkg/reconciler/broker/trigger/controller.go
CONFLICT (content): Merge conflict in pkg/reconciler/broker/trigger/controller.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Reconcile trigger on OIDC service account changes only, if SA references a trigger for correct broker class
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-1.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.