Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix trust bundle propagation #7924

Merged
merged 1 commit into from
May 21, 2024
Merged

Fix trust bundle propagation #7924

merged 1 commit into from
May 21, 2024

Conversation

pierDipi
Copy link
Member

@pierDipi pierDipi commented May 16, 2024 •
edited

Fix TLS-related flaky tests

Fix update conflict and already exists errors:

    wait.go:200: test-yxfagqey/sinkbinding-yilpeqdr condition is {"type":"Ready","status":"False","lastTransitionTime":"2024-05-15T13:29:09Z","reason":"TrustBundlePropagation","message":"failed to update ConfigMap test-yxfagqey/trust-bundle-pvxfnqkskne-bundle: Operation cannot be fulfilled on configmaps \"trust-bundle-pvxfnqkskne-bundle\": the object has been modified; please apply your changes to the latest version and try again"}

@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 16, 2024
@knative-prow knative-prow bot requested review from aliok and odacremolbap May 16, 2024 16:24
@knative-prow knative-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 16, 2024
@pierDipi
Fix trust bundle propagation
9e5699f 
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@pierDipi pierDipi force-pushed the trust-bundle-propagation-fix branch from f79f374 to 9e5699f Compare May 20, 2024 08:12
@pierDipi
Copy link
Member Author

Worked, retesting

/test reconciler-tests

1 similar comment
@pierDipi
Copy link
Member Author

Worked, retesting

/test reconciler-tests

@pierDipi pierDipi changed the title [WIP] Fix trust bundle propagation Fix trust bundle propagation May 20, 2024
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 20, 2024
@pierDipi pierDipi mentioned this pull request May 20, 2024
Open
@pierDipi
Copy link
Member Author

Worked, retesting

/test reconciler-tests

@pierDipi
Copy link
Member Author

Worked again 🎉

/cc @creydr @matzew @Cali0707

@knative-prow knative-prow bot requested review from Cali0707, creydr and matzew May 20, 2024 15:00
creydr
creydr approved these changes May 21, 2024
View reviewed changes
Copy link
Member

@creydr creydr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this 🎉

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 21, 2024
@knative-prow Knative Prow
Copy link

knative-prow bot commented May 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 5355171 into knative:main May 21, 2024
34 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@creydr creydr creydr approved these changes

@aliok aliok Awaiting requested review from aliok

@odacremolbap odacremolbap Awaiting requested review from odacremolbap

@Cali0707 Cali0707 Awaiting requested review from Cali0707

@matzew matzew Awaiting requested review from matzew

Assignees

@creydr creydr

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pierDipi @creydr