-
Notifications
You must be signed in to change notification settings - Fork 581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] CrossNamespace: e2e test to verify event delivery for broker and trigger #7933
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A different test structure could be to create 2 environments so that you don't need to create your namespaces
brokerEnvCtx, brokerEnv := global.Environment(
knative.WithKnativeNamespace(system.Namespace()),
knative.WithLoggingConfig,
knative.WithTracingConfig,
k8s.WithEventListener,
environment.Managed(t),
)
triggerEnvCtx, triggerEnv := global.Environment(
knative.WithKnativeNamespace(system.Namespace()),
knative.WithLoggingConfig,
knative.WithTracingConfig,
k8s.WithEventListener,
environment.Managed(t),
)
brokerEnv.Test(brokerEnvCtx, t, broker.GoesReady(...))
triggerEnv.Test(triggerEnvCtx, t, trigger.CrossNamespaceEventLink(brokerEnvCtx, ...))
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7933 +/- ##
==========================================
- Coverage 67.68% 67.62% -0.06%
==========================================
Files 354 354
Lines 16524 16539 +15
==========================================
+ Hits 11184 11185 +1
- Misses 4650 4665 +15
+ Partials 690 689 -1 ☔ View full report in Codecov by Sentry. |
/test reconciler-tests |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: yijie-04 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test reconciler-tests Looks like the last failure was at least partially due to infra problems |
@yijie-04: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Fixes #7927
Proposed Changes
We should have an e2e test to verify that event delivery for broker and trigger when they are in different namespaces.
Pre-review Checklist
Release Note
Docs