Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EventPolicy types #7995

Merged
merged 4 commits into from
Jun 12, 2024
Merged

Add EventPolicy types #7995

merged 4 commits into from
Jun 12, 2024

Conversation

pierDipi
Copy link
Member

Fixes #7971

Proposed Changes

  • Add EventPolicy types (first commit)
  • Generate client and listers (second commit)
  • Add EventPolicy CRD (third commit)

Pre-review Checklist

  • At least 80% unit test coverage
  • E2E tests for any new behavior
  • Docs PR for any user-facing impact
  • Spec PR for any new API feature
  • Conformance test for any change to the spec

Release Note


Docs

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@knative-prow knative-prow bot added the area/test-and-release Test infrastructure, tests or release label Jun 12, 2024
Copy link

knative-prow bot commented Jun 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 12, 2024
@pierDipi
Copy link
Member Author

/cc @creydr

Copy link

codecov bot commented Jun 12, 2024

Codecov Report

Attention: Patch coverage is 90.54054% with 7 lines in your changes missing coverage. Please review.

Project coverage is 67.67%. Comparing base (b18b1b1) to head (b0f1867).
Report is 2 commits behind head on main.

Files Patch % Lines
...kg/apis/eventing/v1alpha1/eventpolicy_lifecycle.go 60.00% 4 Missing ⚠️
pkg/apis/eventing/v1alpha1/eventpolicy_types.go 66.66% 2 Missing ⚠️
cmd/schema/main.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7995      +/-   ##
==========================================
+ Coverage   67.57%   67.67%   +0.10%     
==========================================
  Files         355      361       +6     
  Lines       16551    16625      +74     
==========================================
+ Hits        11184    11251      +67     
- Misses       4677     4684       +7     
  Partials      690      690              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@creydr
Copy link
Member

creydr commented Jun 12, 2024

Woho that was fast @pierDipi 🚀

Can you check on the build issue?

Error: pkg/apis/eventing/v1alpha1/eventpolicy_lifecycle_test.go:32:11: undefined: EventPolicyConditionReady
Error: pkg/apis/eventing/v1alpha1/eventpolicy_lifecycle_test.go:90:15: undefined: EventPolicyConditionReady

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Copy link
Member

@creydr creydr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Thanks for providing this so fast 💪

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jun 12, 2024
@knative-prow knative-prow bot merged commit 7f37d64 into knative:main Jun 12, 2024
35 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add EventPolicy type
2 participants