Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add default-authorization-mode feature flag #7996

Merged
merged 1 commit into from
Jun 12, 2024
Merged

Add default-authorization-mode feature flag #7996

merged 1 commit into from
Jun 12, 2024

Conversation

pierDipi
Copy link
Member

Fixes #7974

Proposed Changes

  • Add default-authorization-mode feature flag

Pre-review Checklist

  • At least 80% unit test coverage
  • E2E tests for any new behavior
  • Docs PR for any user-facing impact
  • Spec PR for any new API feature
  • Conformance test for any change to the spec

Release Note

Docs

@pierDipi
Add default-authorization-mode feature flag
4a991f7 
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@knative-prow Knative Prow
Copy link

knative-prow bot commented Jun 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 12, 2024
@pierDipi
Copy link
Member Author

/cc @creydr

@knative-prow knative-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 12, 2024
@codecov Codecov
Copy link

codecov bot commented Jun 12, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 54.16667% with 11 lines in your changes missing coverage. Please review.

Project coverage is 67.55%. Comparing base (b18b1b1) to head (4a991f7).
Report is 3 commits behind head on main.

Files Patch % Lines
pkg/apis/feature/features.go 54.16% 6 Missing and 5 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #7996      +/-   ##
==========================================
- Coverage   67.57%   67.55%   -0.03%     
==========================================
  Files         355      355              
  Lines       16551    16564      +13     
==========================================
+ Hits        11184    11189       +5     
- Misses       4677     4683       +6     
- Partials      690      692       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

creydr
creydr reviewed Jun 12, 2024
View reviewed changes
config/core/configmaps/features.yaml
# authorization mode for resources that have no EventPolicy associated with them.
#
# This feature flag is only used when "authentication-oidc" is enabled.
default-authorization-mode: "allow-same-namespace"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we use "allow-all" as the default at the beginning, to not break users?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is applied only when authn is enabled and that feature is alpha, I'd go directly with the one that is most sensible for the future ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

@pierDipi
Copy link
Member Author

/test upgrade-tests

@pierDipi pierDipi requested a review from creydr June 12, 2024 12:52
creydr
creydr reviewed Jun 12, 2024
View reviewed changes
Copy link
Member

@creydr creydr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jun 12, 2024
@knative-prow knative-prow bot merged commit 8da4543 into knative:main Jun 12, 2024
35 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@creydr creydr creydr left review comments

@aliok aliok Awaiting requested review from aliok

@lionelvillard lionelvillard Awaiting requested review from lionelvillard

Assignees

@creydr creydr

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add default-authorization-mode feature flag
2 participants
@pierDipi @creydr