Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Fix for test failures of knative/serving#13292 #227

Merged
merged 2 commits into from
Sep 14, 2022
Merged

🐛 Fix for test failures of knative/serving#13292 #227

merged 2 commits into from
Sep 14, 2022

Conversation

cardil
Copy link
Contributor

@cardil cardil commented Sep 14, 2022

Changes

/kind bug

Fixes tests for knative/serving#13292

@knative-prow knative-prow bot added kind/bug Categorizes issue or PR as related to a bug. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 14, 2022
@cardil cardil changed the title 🐛 Fix for test failures of knative/serving#13292 [wip] 🐛 Fix for test failures of knative/serving#13292 Sep 14, 2022
@knative-prow knative-prow bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Sep 14, 2022
@cardil cardil mentioned this pull request Sep 14, 2022
Merged
@cardil
Repro of knative/serving#13292
387a91e 
Signed-off-by: Chris Suszyński <ksuszyns@redhat.com>
@knative-prow knative-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 14, 2022
@cardil cardil mentioned this pull request Sep 14, 2022
Closed
@cardil
Copy link
Contributor Author

cardil commented Sep 14, 2022

Some git related flake.

/test unit-tests

@cardil cardil changed the title [wip] 🐛 Fix for test failures of knative/serving#13292 🐛 Fix for test failures of knative/serving#13292 Sep 14, 2022
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 14, 2022
@cardil
Copy link
Contributor Author

cardil commented Sep 14, 2022

/assign @dprotaso
/cc @upodroid
/cc @mgencur

@dprotaso
Copy link
Member

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 14, 2022
@knative-prow
Copy link

knative-prow bot commented Sep 14, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cardil, dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit df80419 into knative:main Sep 14, 2022
@cardil cardil deleted the bugfix/subshell-removal branch September 14, 2022 13:07
@lionelvillard lionelvillard mentioned this pull request Sep 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgencur mgencur Awaiting requested review from mgencur

@upodroid upodroid Awaiting requested review from upodroid

Assignees

@dprotaso dprotaso

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cardil @dprotaso