Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make kingress conformance amenable to KinD #139

Merged
merged 2 commits into from Sep 6, 2020
Merged

Make kingress conformance amenable to KinD #139

merged 2 commits into from Sep 6, 2020

Conversation

mattmoor
Copy link
Member

@mattmoor mattmoor commented Sep 6, 2020

Two main changes:

  1. Use imagePullPolicy: IfNotPresent to support preloading the test images with ko + kind.local
  2. Don't require the service exposed in the kingress status to have type LoadBalancer when we've been handed an --ingressendpoint. This is indicative of local environments like KinD or minikube where the type: LoadBalancer service may have been changes to type: NodePort.

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Sep 6, 2020
@knative-prow-robot knative-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 6, 2020
@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 6, 2020
@mattmoor
Copy link
Member Author

mattmoor commented Sep 6, 2020

cc @nak3 @ZhiminXiang

@mattmoor
Copy link
Member Author

mattmoor commented Sep 6, 2020

I feel like --ingressendpoint is going to be inadequate because we won't hit the same port for both http and https.

Perhaps the proper fix would be to allow the service to be NodePort when an IP is specified via --ingressendpoint and select the appropriate node port from the service...

@mattmoor
Make kingress conformance amenable to KinD
bad5f11 
Two main changes:
1. Use `imagePullPolicy: IfNotPresent` to support preloading the test images with `ko` + `kind.local`
2. Don't require the service exposed in the kingress status to have type LoadBalancer when we've been handed an `--ingressendpoint`.  This is indicative of local environments like KinD or minikube where the `type: LoadBalancer` service may have been changes to `type: NodePort`.
vagababov
vagababov reviewed Sep 6, 2020
View reviewed changes
Copy link
Contributor

@vagababov vagababov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The better name for the branch would be kinder 😬

test/conformance/ingress/util.go Outdated Show resolved Hide resolved
test/conformance/ingress/util.go Show resolved Hide resolved
@mattmoor
Copy link
Member Author

mattmoor commented Sep 6, 2020

Here's a run of kingress conformance passing with this vendored: https://github.com/mattmoor/net-contour/runs/1079033774?check_suite_focus=true

tcnghia
tcnghia approved these changes Sep 6, 2020
View reviewed changes
Copy link
Contributor

@tcnghia tcnghia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 6, 2020
@knative-prow-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mattmoor, tcnghia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit d51e179 into knative:master Sep 6, 2020
@mattmoor mattmoor deleted the better-kind branch September 6, 2020 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vagababov vagababov vagababov left review comments

@tcnghia tcnghia tcnghia approved these changes

@chaodaiG chaodaiG Awaiting requested review from chaodaiG

@steuhs steuhs Awaiting requested review from steuhs

Assignees

@tcnghia tcnghia

@markusthoemmes markusthoemmes

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@mattmoor @knative-prow-robot @tcnghia @vagababov @markusthoemmes @googlebot