Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make kingress conformance amenable to KinD #139

Merged
merged 2 commits into from Sep 6, 2020
Merged

Make kingress conformance amenable to KinD #139

merged 2 commits into from Sep 6, 2020

Commits on Sep 6, 2020

  1. Make kingress conformance amenable to KinD 

    Two main changes:
1. Use `imagePullPolicy: IfNotPresent` to support preloading the test images with `ko` + `kind.local`
2. Don't require the service exposed in the kingress status to have type LoadBalancer when we've been handed an `--ingressendpoint`.  This is indicative of local environments like KinD or minikube where the `type: LoadBalancer` service may have been changes to `type: NodePort`.
    @mattmoor
    mattmoor committed Sep 6, 2020
    Configuration menu
    Copy the full SHA
    bad5f11 View commit details
    Browse the repository at this point in the history

  2. vagababov feedback

    @mattmoor
    mattmoor committed Sep 6, 2020
    Configuration menu
    Copy the full SHA
    f13cc65 View commit details
    Browse the repository at this point in the history