Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the conversion function for v1alpha1 and v1beta1 #948

Merged
merged 1 commit into from
Feb 4, 2022

Conversation

houshengbo
Copy link
Contributor

@houshengbo houshengbo commented Feb 3, 2022

This PR has done the following updates:

  • Added the conversion function between v1alpha1 and v1beta1 APIs.
  • Gateways information can be passed to v1beta1 API during the v1alpha1 to v1beta1 conversion.
  • System resources configuration can be passed to v1beta1 API during the v1alpha1 to v1beta1 conversion.
  • The v1beta1 API removed all the deprecated fields in v1alpha1, including ResourceRequirementsOverride, DeprecatedKnativeIngressGateway and DeprecatedClusterLocalGateway.

@knative-prow-robot knative-prow-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 3, 2022
@codecov
Copy link

codecov bot commented Feb 3, 2022

Codecov Report

Merging #948 (598b732) into main (ff6232d) will increase coverage by 2.42%.
The diff coverage is 95.69%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #948      +/-   ##
==========================================
+ Coverage   81.21%   83.64%   +2.42%     
==========================================
  Files          35       41       +6     
  Lines        1006     1192     +186     
==========================================
+ Hits          817      997     +180     
- Misses        119      125       +6     
  Partials       70       70              
Impacted Files Coverage Δ
...pis/operator/v1alpha1/knativeserving_conversion.go 92.59% <92.59%> (ø)
...is/operator/v1alpha1/knativeeventing_conversion.go 95.78% <95.78%> (ø)
pkg/apis/operator/v1alpha1/deploymentoverride.go 100.00% <100.00%> (ø)
pkg/apis/operator/v1alpha1/istioconfig.go 100.00% <100.00%> (ø)
...pis/operator/v1beta1/knativeeventing_conversion.go 100.00% <100.00%> (ø)
...apis/operator/v1beta1/knativeserving_conversion.go 100.00% <100.00%> (ø)
pkg/apis/operator/v1alpha1/knativeserving_types.go 50.00% <0.00%> (+50.00%) ⬆️
...kg/apis/operator/v1alpha1/knativeeventing_types.go 50.00% <0.00%> (+50.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff6232d...598b732. Read the comment docs.

@houshengbo houshengbo force-pushed the add-api-conversion branch 3 times, most recently from 0f985de to 20609d0 Compare February 3, 2022 17:40
@houshengbo
Copy link
Contributor Author

/test pull-knative-operator-serving-upgrade-tests

2 similar comments
@houshengbo
Copy link
Contributor Author

/test pull-knative-operator-serving-upgrade-tests

@houshengbo
Copy link
Contributor Author

/test pull-knative-operator-serving-upgrade-tests

Copy link

@maximilien maximilien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 4, 2022
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: houshengbo, maximilien

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@houshengbo
Copy link
Contributor Author

/test pull-knative-operator-serving-upgrade-tests

3 similar comments
@houshengbo
Copy link
Contributor Author

/test pull-knative-operator-serving-upgrade-tests

@houshengbo
Copy link
Contributor Author

/test pull-knative-operator-serving-upgrade-tests

@houshengbo
Copy link
Contributor Author

/test pull-knative-operator-serving-upgrade-tests

@knative-prow-robot knative-prow-robot removed the lgtm Indicates that a PR is ready to be merged. label Feb 4, 2022
@knative-prow-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/operator/v1alpha1/deploymentoverride.go Do not exist 100.0%
pkg/apis/operator/v1alpha1/istioconfig.go Do not exist 100.0%
pkg/apis/operator/v1alpha1/knativeeventing_conversion.go Do not exist 95.7%
pkg/apis/operator/v1alpha1/knativeserving_conversion.go Do not exist 85.7%
pkg/apis/operator/v1beta1/knativeeventing_conversion.go Do not exist 100.0%
pkg/apis/operator/v1beta1/knativeserving_conversion.go Do not exist 100.0%

@houshengbo houshengbo added the lgtm Indicates that a PR is ready to be merged. label Feb 4, 2022
@knative-prow-robot knative-prow-robot merged commit 8298146 into knative:main Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants