Generation variant of kmeta/labels.go #116
Assignees
Labels
Comments
mattmoor
added a commit
to mattmoor/pkg
that referenced
this issue
Oct 7, 2018
Unlike `ResourceVersion`, which changes whenever the resource changes at all (including `/status` which can be high churn), `Generation` only changes when the `/spec` of a CRD changes (for CRDs starting in 1.11, right now they are locked at `generation: 1`). These methods are useful for interacting with K8s resource now, and will be useful for CRDs soon. Fixes: knative#116
knative-prow-robot
pushed a commit
that referenced
this issue
Oct 8, 2018
Unlike `ResourceVersion`, which changes whenever the resource changes at all (including `/status` which can be high churn), `Generation` only changes when the `/spec` of a CRD changes (for CRDs starting in 1.11, right now they are locked at `generation: 1`). These methods are useful for interacting with K8s resource now, and will be useful for CRDs soon. Fixes: #116
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This code deals with
ResourceVersion. The current use ofResourceVersionstems from the Kubernetes bug where it fails to bumpGenerationfor CRDs (still affects us until we move to 1.11 w//statussubresource).For CRDs without status (e.g. WarmImage, BuildTemplate)
ResourceVersionis a useful stand-in because it changes at roughly the same pace asSpec.However, for resources with status (e.g. Revision, or K8s resources) the methods we have are of limited use because they are too high-churn; this is because
ResourceVersionwill change every time/statuschanges as well, making the current methods unsuitable for child-resource instantiation for these parent resources.These
Generationvariants will only be useful for our own CRDs once we're on 1.11, but once we are they should become the standard way of achieving this.The text was updated successfully, but these errors were encountered: