Add Generation variants of kmeta/labels.go #117
Conversation
Unlike `ResourceVersion`, which changes whenever the resource changes at all (including `/status` which can be high churn), `Generation` only changes when the `/spec` of a CRD changes (for CRDs starting in 1.11, right now they are locked at `generation: 1`). These methods are useful for interacting with K8s resource now, and will be useful for CRDs soon. Fixes: knative#116
knative-prow-robot
added
size/L
There was a problem hiding this comment.
@mattmoor: 0 warnings.
In response to this:
Unlike
ResourceVersion, which changes whenever the resource changes at all (including/statuswhich can be high churn),Generationonly changes when the/specof a CRD changes (for CRDs starting in 1.11, right now they are locked atgeneration: 1).These methods are useful for interacting with K8s resource now, and will be useful for CRDs soon.
Fixes: #116
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
|
The following is the coverage report on pkg/.
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mattmoor, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Unlike
ResourceVersion, which changes whenever the resource changes at all (including/statuswhich can be high churn),Generationonly changes when the/specof a CRD changes (for CRDs starting in 1.11, right now they are locked atgeneration: 1).These methods are useful for interacting with K8s resource now, and will be useful for CRDs soon.
Fixes: #116