Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement WaitForEndpointSteadyState helper #1176

Closed
wants to merge 1 commit into from
Closed

Implement WaitForEndpointSteadyState helper #1176

wants to merge 1 commit into from

Conversation

mgencur
Copy link
Contributor

@mgencur mgencur commented Mar 26, 2020 •
edited
Loading

  • this helper waits until a condition is met for the given number of
    times in a row
  • this can be useful if requests go through multiple different
    components (e.g. routers) and we want to wait until all the components
    are ready and requests going through any of the components will succeed

PR for knative/serving will be sent shortly: TBD

@mgencur
Implement WaitForEndpointSteadyState helper
310e7c1 
* this helper waits until a condition is met for the given number of
times in a row
* this can be useful if requests go through multiple different
components (e.g. routers) and we want to wait until all the components
are ready and requests going through any of the components will succeed
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Mar 26, 2020
@knative-prow-robot knative-prow-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/test-and-release labels Mar 26, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mgencur
To complete the pull request process, please assign chizhg
You can assign the PR to them by writing /assign @chizhg in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mgencur
Copy link
Contributor Author

mgencur commented Mar 26, 2020

Closing for now until I find a better solution.

@mgencur mgencur closed this Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaodaiG chaodaiG Awaiting requested review from chaodaiG

@chizhg chizhg Awaiting requested review from chizhg

Assignees
No one assigned
Labels
area/test-and-release cla: yes Indicates the PR's author has signed the CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mgencur @knative-prow-robot @googlebot