Skip to content

Commit

Permalink
[RELEASE 0.8] Kill kail process after test (#5305)
Browse files Browse the repository at this point in the history
This is a cherry-pick of #5239:

kail is started as a background process during test setup, and causes a few random errors at the end of Prow jobs. Kill it to avoid those errors.

Update: just confirmed that these errors also added ~10 minutes to e2e tests.
  • Loading branch information
adrcunha authored and knative-prow-robot committed Aug 27, 2019
1 parent 97ef646 commit 6da659b
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions test/e2e-common.sh
Original file line number Diff line number Diff line change
Expand Up @@ -299,6 +299,9 @@ function test_setup() {

# Capture all logs.
kail > ${ARTIFACTS}/k8s.log.txt &
local kail_pid=$!
# Clean up kail so it doesn't interfere with job shutting down
trap "kill $kail_pid || true" EXIT

echo ">> Creating test resources (test/config/)"
ko apply ${KO_FLAGS} -f test/config/ || return 1
Expand Down

0 comments on commit 6da659b

Please sign in to comment.