Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activator should be healthy iff it is in contact with stat server #3508

Closed
mattmoor opened this issue Mar 24, 2019 · 4 comments
Closed

Activator should be healthy iff it is in contact with stat server #3508

mattmoor opened this issue Mar 24, 2019 · 4 comments
Labels
area/autoscale area/networking kind/bug Categorizes issue or PR as related to a bug.
Milestone

Comments

@mattmoor
Copy link
Member

In what area(s)?

/area autoscale
/area networking

What version of Knative?

HEAD

Expected Behavior

The activator fundamentally needs to be able to send metrics to the autoscaler to perform its function, if that connection hasn't been established, or gets broken, then the activator must start failing health checks.

Actual Behavior

The activator happily accepts requests and simply logs that it hasn't connected to the stats endpoint yet.

Steps to Reproduce the Problem

If you disable the stats endpoint on the autoscaler (scraping will still work above zero) then things will fail to scale from zero despite the activator looking perfectly healthy.

@mattmoor
Copy link
Member Author

We should add a handler here that exposes a way to health check things and back it with status from the sink here

@markusthoemmes
Copy link
Contributor

Related to #2857

@mattmoor
Copy link
Member Author

I see a PR from @jsanda that's somewhat inactive, but doesn't cover this. Do you know if he's actively working on this?

@mattmoor
Copy link
Member Author

I need something for idle hands on the shuttle, I'll see how far I get :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/autoscale area/networking kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

No branches or pull requests

4 participants