Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduces the boilerplate of our controller binaries. #3503

Merged
merged 2 commits into from Mar 24, 2019
Merged

Reduces the boilerplate of our controller binaries. #3503

merged 2 commits into from Mar 24, 2019

Conversation

mattmoor
Copy link
Member

No description provided.

@knative-prow-robot knative-prow-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 23, 2019
@knative-prow-robot knative-prow-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Mar 23, 2019
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mattmoor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/API API objects and controllers area/autoscale labels Mar 23, 2019
@mattmoor mattmoor mentioned this pull request Mar 23, 2019
Merged
@knative-prow-robot knative-prow-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 23, 2019
@mattmoor mattmoor changed the title [WIP] Reduces the boilerplate of our controller binaries. Reduces the boilerplate of our controller binaries. Mar 23, 2019
@knative-prow-robot knative-prow-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 23, 2019
@mattmoor mattmoor mentioned this pull request Mar 23, 2019
Merged
@markusthoemmes
Copy link
Contributor

Coverage dropped to below 50%, is that fixable?

@mattmoor
Copy link
Member Author

/hold

Yeah, definitely not intended, but what I get for moving code out of ignored directories! :)

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 23, 2019
@mattmoor
Copy link
Member Author

/hold

Too many failures, need to dig deeper.

@mattmoor
Copy link
Member Author

Forgot that I switched this to blocking when I moved to knative/pkg. This should be RFAL now.

I also filed #3508 which was the somewhat unintuitive failure more I was seeing.

/hold cancel

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 24, 2019
@knative-metrics-robot
Copy link

The following is the coverage report on pkg/.
Say /test pull-knative-serving-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/reconciler.go 89.5% 91.7% 2.2

vagababov
vagababov reviewed Mar 24, 2019
View reviewed changes
Copy link
Contributor

@vagababov vagababov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 24, 2019
@knative-prow-robot knative-prow-robot merged commit ab9ef7a into knative:master Mar 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vagababov vagababov vagababov left review comments

@dprotaso dprotaso Awaiting requested review from dprotaso

@jonjohnsonjr jonjohnsonjr Awaiting requested review from jonjohnsonjr

@markusthoemmes markusthoemmes Awaiting requested review from markusthoemmes

Assignees

@vagababov vagababov

@n3wscott n3wscott

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/API API objects and controllers area/autoscale lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@mattmoor @knative-prow-robot @markusthoemmes @knative-metrics-robot @vagababov @n3wscott