Do not call GetIngressEndpoint() when --resolvabledomain is enabled #11318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`GetIngressEndpoint()` is a function to get ingress endpoint for the spoof client. So we don't need to call it when `--resolvabledomain` is enabled. Especially when Ingresss service uses `ClusterIP`, it alwasy fails to get endpoint and test fails. This patch changes to call GetIngressEndpoint() only when resolvabledomain is false in websocket test.
knative-prow-robot
added
size/S
Codecov Report
@@ Coverage Diff @@
## main #11318 +/- ##
==========================================
- Coverage 87.74% 87.72% -0.03%
==========================================
Files 191 191
Lines 9211 9211
==========================================
- Hits 8082 8080 -2
- Misses 876 878 +2
Partials 253 253
Continue to review full report at Codecov.
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: markusthoemmes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
nak3
added a commit
to nak3/serving
that referenced
this pull request
Jun 11, 2021
…native#11318) `GetIngressEndpoint()` is a function to get ingress endpoint for the spoof client. So we don't need to call it when `--resolvabledomain` is enabled. Especially when Ingresss service uses `ClusterIP`, it alwasy fails to get endpoint and test fails. This patch changes to call GetIngressEndpoint() only when resolvabledomain is false in websocket test.
openshift-merge-robot
pushed a commit
to openshift/knative-serving
that referenced
this pull request
Jun 15, 2021
* Do not call GetIngressEndpoint() when --resolvabledomain is enabled (knative#11318) `GetIngressEndpoint()` is a function to get ingress endpoint for the spoof client. So we don't need to call it when `--resolvabledomain` is enabled. Especially when Ingresss service uses `ClusterIP`, it alwasy fails to get endpoint and test fails. This patch changes to call GetIngressEndpoint() only when resolvabledomain is false in websocket test. * Use TLS for websocket and gRPC tests (knative#11322) * Support websocket https * Use TLS for websocket and gRPC tests Current gRPC and Websocket does not use TLS, but still uses HTTP even when it runs with HTTPS mode. This patch fixes it. * Add ServerName to pseudo host with TLS. * Decrease the length of test name * Fix race issue * Add workaround only https * try dialer option * Without parallel * Use a single DialOption * Revert "Without parallel" This reverts commit 99455a6. * Revert "Revert "Without parallel"" This reverts commit 7105cbc. * Fix TestGRPCStreamingPingViaActivator * Do not run gRPC with parallel * Add TODO comment * Use net.SplitHostPort * make long ksvc name generic * Revert "make long ksvc name generic" This reverts commit 4119f08.
markusthoemmes
pushed a commit
to openshift/knative-serving
that referenced
this pull request
Jun 22, 2021
* Do not call GetIngressEndpoint() when --resolvabledomain is enabled (knative#11318) `GetIngressEndpoint()` is a function to get ingress endpoint for the spoof client. So we don't need to call it when `--resolvabledomain` is enabled. Especially when Ingresss service uses `ClusterIP`, it alwasy fails to get endpoint and test fails. This patch changes to call GetIngressEndpoint() only when resolvabledomain is false in websocket test. * Use TLS for websocket and gRPC tests (knative#11322) * Support websocket https * Use TLS for websocket and gRPC tests Current gRPC and Websocket does not use TLS, but still uses HTTP even when it runs with HTTPS mode. This patch fixes it. * Add ServerName to pseudo host with TLS. * Decrease the length of test name * Fix race issue * Add workaround only https * try dialer option * Without parallel * Use a single DialOption * Revert "Without parallel" This reverts commit 99455a6. * Revert "Revert "Without parallel"" This reverts commit 7105cbc. * Fix TestGRPCStreamingPingViaActivator * Do not run gRPC with parallel * Add TODO comment * Use net.SplitHostPort * make long ksvc name generic * Revert "make long ksvc name generic" This reverts commit 4119f08.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GetIngressEndpoint()is a function to get ingress endpoint for thespoof client. So we don't need to call it when
--resolvabledomainisenabled. Especially when Ingresss service uses
ClusterIP, it alwasyfails to get endpoint and test fails.
This patch changes to call GetIngressEndpoint() only when
resolvabledomain is false in websocket test.