Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Automated] Update net-istio nightly #13524

Merged

Conversation

knative-automation
Copy link
Contributor

/assign @knative/networking-wg-leads
/cc @knative/networking-wg-leads

Produced via:

for x in net-istio.yaml; do
  curl https://storage.googleapis.com/knative-nightly/net-istio/latest/$x > ${GITHUB_WORKSPACE}/./third_party/istio-latest/$x
done

Details:

bumping knative.dev/net-istio c5d5ea5...345dc1b:
  > 345dc1b Explicitly set minProtocolVersion (# 1030)

bumping knative.dev/net-istio c5d5ea5...345dc1b:
  > 345dc1b Explicitly set minProtocolVersion (# 1030)

Signed-off-by: Knative Automation <automation@knative.team>
@knative-prow knative-prow bot requested a review from a team November 30, 2022 11:06
@knative-prow knative-prow bot added area/networking size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 30, 2022
@codecov
Copy link

codecov bot commented Nov 30, 2022

Codecov Report

Base: 86.43% // Head: 86.43% // No change to project coverage 👍

Coverage data is based on head (2b51e2a) compared to base (0ea12f4).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13524   +/-   ##
=======================================
  Coverage   86.43%   86.43%           
=======================================
  Files         196      196           
  Lines       14600    14600           
=======================================
  Hits        12619    12619           
  Misses       1680     1680           
  Partials      301      301           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@psschwei psschwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 30, 2022
@knative-prow
Copy link

knative-prow bot commented Nov 30, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: knative-automation, psschwei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 30, 2022
@knative-prow knative-prow bot merged commit 327bf91 into knative:main Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/networking lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants