Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wip] Integrate net-certmanager in Serving #14955

Closed
wants to merge 24 commits into from

test istio tls

df32c33
Select commit
Loading
Failed to load commit list.
Closed

[wip] Integrate net-certmanager in Serving #14955

test istio tls
df32c33
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Mar 29, 2024 in 0s

83.95% (target 80.00%)

View this Pull Request on Codecov

83.95% (target 80.00%)

Details

Codecov Report

Attention: Patch coverage is 77.87934% with 121 lines in your changes are missing coverage. Please review.

Project coverage is 83.95%. Comparing base (74622fb) to head (df32c33).

Files Patch % Lines
cmd/controller/main.go 0.00% 43 Missing ⚠️
...-certmanager/reconciler/certificate/certificate.go 85.54% 14 Missing and 10 partials ⚠️
.../certificate/resources/cert_manager_certificate.go 84.42% 19 Missing ⚠️
cmd/webhook/main.go 0.00% 12 Missing ⚠️
pkg/net-certmanager/reconciler/testing/factory.go 83.92% 7 Missing and 2 partials ⚠️
pkg/net-certmanager/reconciler/testing/listers.go 81.39% 8 Missing ⚠️
...ager/reconciler/certificate/config/cert_manager.go 71.42% 4 Missing and 2 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #14955      +/-   ##
==========================================
- Coverage   84.03%   83.95%   -0.08%     
==========================================
  Files         213      220       +7     
  Lines       16783    17318     +535     
==========================================
+ Hits        14103    14539     +436     
- Misses       2324     2413      +89     
- Partials      356      366      +10

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov