Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup resources from DeploymentFailure upgrade test #15227

Merged
merged 1 commit into from
May 23, 2024

Conversation

mgencur
Copy link
Contributor

@mgencur mgencur commented May 22, 2024

Proposed Changes

  • Clean up the resources when the test ends (webhook, knative service) as the namespace might be used for running other tests afterwards (e.g. other Serving E2E tests or upgrade tests for cluster-upgrades)

Release Note


@knative-prow knative-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 22, 2024
@knative-prow knative-prow bot requested review from ReToCode and skonto May 22, 2024 06:32
Copy link

codecov bot commented May 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.77%. Comparing base (c2d0af1) to head (f7b4f21).
Report is 117 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15227      +/-   ##
==========================================
+ Coverage   84.11%   84.77%   +0.66%     
==========================================
  Files         213      218       +5     
  Lines       16783    13473    -3310     
==========================================
- Hits        14117    11422    -2695     
+ Misses       2315     1685     -630     
- Partials      351      366      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ReToCode ReToCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 23, 2024
Copy link

knative-prow bot commented May 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mgencur, ReToCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 23, 2024
@knative-prow knative-prow bot merged commit fa7eaa2 into knative:main May 23, 2024
68 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants