Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add configmap for clusteringress #2486

Merged
merged 2 commits into from
Nov 19, 2018
Merged

Add configmap for clusteringress #2486

merged 2 commits into from
Nov 19, 2018

Conversation

lichuqiang
Copy link
Contributor

First step to address #1969
Part of #2434
Split this into separate PR for review.

Proposed Changes

  • add ingress gateway configmap

Release Note

allow config ingress gateway

@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 14, 2018
knative-prow-robot
knative-prow-robot reviewed Nov 14, 2018
View reviewed changes
Copy link
Contributor

@knative-prow-robot knative-prow-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lichuqiang: 0 warnings.

In response to this:

First step to address #1969
Part of #2434
Split this into separate PR for review.

Proposed Changes

  • add ingress gateway configmap

Release Note

allow config ingress gateway

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lichuqiang
Copy link
Contributor Author

/assign @tcnghia @mattmoor

mattmoor
mattmoor reviewed Nov 15, 2018
View reviewed changes
config/config-ingressgateway.yaml Outdated
namespace: knative-serving
data:
# Gateway used for knative traffic. Default to istio-ingressgateway.
ingress-gateway: "istio-ingressgateway.istio-system.svc.cluster.local"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: newline

config/config-ingressgateway.yaml Outdated
apiVersion: v1
kind: ConfigMap
metadata:
name: config-ingressgateway
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm worried that this name is overly specific, perhaps we could call this config-istio and have it hold the istio-specific concepts that our networking controllers back by istio need?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to having one config map for Istio related settings. I think there are a few Istio items in config-networking that could move here as well (in a later PR).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@knative-metrics-robot
Copy link

The following is the coverage report on pkg/.
Say /test pull-knative-serving-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/v1alpha1/clusteringress/config/istio.go Do not exist 100.0%
pkg/reconciler/v1alpha1/clusteringress/config/store.go Do not exist 100.0%

@tcnghia
Copy link
Contributor

tcnghia commented Nov 16, 2018

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 16, 2018
@mattmoor
Copy link
Member

/approve

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lichuqiang, mattmoor, tcnghia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 19, 2018
@knative-prow-robot knative-prow-robot merged commit e513e2f into knative:master Nov 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattmoor mattmoor mattmoor left review comments

@knative-prow-robot knative-prow-robot knative-prow-robot left review comments

@ericKlawitter ericKlawitter Awaiting requested review from ericKlawitter

@tcnghia tcnghia Awaiting requested review from tcnghia

Assignees

@tcnghia tcnghia

@mattmoor mattmoor

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@lichuqiang @knative-metrics-robot @tcnghia @mattmoor @knative-prow-robot