-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Investigate using istio-ingressgateway
by default
#1969
Comments
TODO(knative#1969): We should allow the users to use `istio-ingressgateway` by default, while having the choice to specify their own Ingress Gateway service if that isn't enough for them. That way we can get out of maintaining these YAML ourselves.
TODO(knative#1969): We should allow the users to use `istio-ingressgateway` by default, while having the choice to specify their own Ingress Gateway service if that isn't enough for them. That way we can get out of maintaining these YAML ourselves.
However for backward compatibility we probably want to keep providing |
@tcnghia Since Knative is in alpha or beta stage it's common case if backward compatibility got broken. More important to keep fast development to get it to the production stage. |
TODO(#1969): We should allow the users to use `istio-ingressgateway` by default, while having the choice to specify their own Ingress Gateway service if that isn't enough for them. That way we can get out of maintaining these YAML ourselves.
/cc |
/assign @lichuqiang |
Took a closer look at the issue, here are general thoughts:
and here are the tasks I think needed to achieve this:
|
@lichuqiang #1,#2 sound good to me. |
Per discussion with @jonjohnsonjr and @mattmoor we will extend feature this to allow exposing to multiple ingress gateway to allow users to easily migrate without disruption. In 0.3 we will expose to both knative-ingressgateway and istio-ingressgateway. In 0.4 we will only expose to istio-ingressgateway. |
Expected Behavior
Knative Serving installation does not need to install something in
istio-system
namespace. Knative Serving does not have to keep up with changes in Envoy proxy images.Actual Behavior
We are installing an ELB
knative-ingressgateway
intoistio-system
namespace. Also, we are using a copy of Istio ELBistio-ingressgateway
which requires making sure it is up-to-date with Istio's.This was so that our Gateway can use those pods without conflicting with users' own Gateways.
However, Istio 1.0.1 may in better merging of Gateways, so may be we can base on Gateway Hosts to avoid conflicting (this didn't work with 0.8). Also Istio now have validation so users Gateway conflict may be less confusing than before (silent unavailability of service)
We should investigate allowing the users to choose what ingressgateway ELB they can use, which defaults to the Istio default
istio-ingressgateway
. This way we not only avoid maintaining this service ourselves, we also avoid installing things intoistio-system
namespace and save the user 1 static IP.The text was updated successfully, but these errors were encountered: