v1beta1 api conformance testing #4369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow-robot
added
the
size/XXL
|
/hold For now. |
knative-prow-robot
added
the
do-not-merge/hold
knative-prow-robot
requested review from
adrcunha,
dushyanthsc and
srinivashegde86
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mattmoor The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
approved
|
cc @cooperneil FYI |
dgerd
reviewed
Jun 14, 2019
|
/hold cancel |
knative-prow-robot
removed
the
do-not-merge/hold
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change has two main parts:
./test/conformance/api/v1alpha1testing targetingv1beta1.Two notable deviations I made as part of this work are:
PatchFooto take a list of functional options to determine the patch.Optionstype in favor of functional options everywhere.I fleshed out enough of the v1beta1 directories a few places to create these end-to-end tests.
Fixes: #4365