Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1beta1 api conformance testing #4369

Merged
merged 4 commits into from Jun 14, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 2 additions & 3 deletions hack/update-codegen.sh
Expand Up @@ -34,13 +34,13 @@ KNATIVE_CODEGEN_PKG=${KNATIVE_CODEGEN_PKG:-$(cd ${REPO_ROOT_DIR}; ls -d -1 ./ven
# instead of the $GOPATH directly. For normal projects this can be dropped.
${CODEGEN_PKG}/generate-groups.sh "deepcopy,client,informer,lister" \
github.com/knative/serving/pkg/client github.com/knative/serving/pkg/apis \
"serving:v1alpha1 autoscaling:v1alpha1 networking:v1alpha1" \
"serving:v1alpha1,v1beta1 autoscaling:v1alpha1 networking:v1alpha1" \
--go-header-file ${REPO_ROOT_DIR}/hack/boilerplate/boilerplate.go.txt

# Knative Injection
${KNATIVE_CODEGEN_PKG}/hack/generate-knative.sh "injection" \
github.com/knative/serving/pkg/client github.com/knative/serving/pkg/apis \
"serving:v1alpha1 autoscaling:v1alpha1 networking:v1alpha1" \
"serving:v1alpha1,v1beta1 autoscaling:v1alpha1 networking:v1alpha1" \
--go-header-file ${REPO_ROOT_DIR}/hack/boilerplate/boilerplate.go.txt

# Generate our own client for cert-manager (otherwise injection won't work)
Expand All @@ -60,7 +60,6 @@ ${GOPATH}/bin/deepcopy-gen \
-O zz_generated.deepcopy \
--go-header-file ${REPO_ROOT_DIR}/hack/boilerplate/boilerplate.go.txt \
-i github.com/knative/serving/pkg/apis/config \
-i github.com/knative/serving/pkg/apis/serving/v1beta1 \
-i github.com/knative/serving/pkg/reconciler/clusteringress/config \
-i github.com/knative/serving/pkg/reconciler/certificate/config \
-i github.com/knative/serving/pkg/reconciler/configuration/config \
Expand Down
2 changes: 1 addition & 1 deletion pkg/activator/handler/handler_test.go
Expand Up @@ -765,7 +765,7 @@ func revisionLister(revs ...*v1alpha1.Revision) servinglisters.RevisionLister {
revisions := informer.Serving().V1alpha1().Revisions()

for _, rev := range revs {
fake.Serving().Revisions(rev.Namespace).Create(rev)
fake.ServingV1alpha1().Revisions(rev.Namespace).Create(rev)
revisions.Informer().GetIndexer().Add(rev)
}

Expand Down
5 changes: 5 additions & 0 deletions pkg/apis/serving/v1beta1/revision_lifecycle.go
Expand Up @@ -22,6 +22,11 @@ import (
"github.com/knative/pkg/apis"
)

const (
// DefaultUserPort is the system default port value exposed on the user-container.
DefaultUserPort = 8080
)

var revisionCondSet = apis.NewLivingConditionSet()

// GetGroupVersionKind returns the GroupVersionKind.
Expand Down
20 changes: 17 additions & 3 deletions pkg/client/clientset/versioned/clientset.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

13 changes: 10 additions & 3 deletions pkg/client/clientset/versioned/fake/clientset_generated.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions pkg/client/clientset/versioned/fake/register.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions pkg/client/clientset/versioned/scheme/register.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

174 changes: 174 additions & 0 deletions pkg/client/clientset/versioned/typed/serving/v1beta1/configuration.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

20 changes: 20 additions & 0 deletions pkg/client/clientset/versioned/typed/serving/v1beta1/doc.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

20 changes: 20 additions & 0 deletions pkg/client/clientset/versioned/typed/serving/v1beta1/fake/doc.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.