Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Bug Report Template to ask for Git SHA #4601

Merged
merged 2 commits into from
Jul 4, 2019
Merged

Update Bug Report Template to ask for Git SHA #4601

merged 2 commits into from
Jul 4, 2019

Conversation

dprotaso
Copy link
Member

@dprotaso dprotaso commented Jul 2, 2019

HEAD moves fast

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jul 2, 2019
@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 2, 2019
@dgerd
Copy link

dgerd commented Jul 3, 2019

/lgtm
/approved

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 3, 2019
@dgerd
Copy link

dgerd commented Jul 3, 2019

Well I used the wrong tense of "approve", but looks like I cannot do it anyways.

/assign @evankanderson

mattmoor
mattmoor reviewed Jul 4, 2019
View reviewed changes
Copy link
Member

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, mattmoor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 4, 2019
@knative-prow-robot knative-prow-robot merged commit 755e258 into knative:master Jul 4, 2019
@dprotaso dprotaso deleted the patch-2 branch February 1, 2023 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattmoor mattmoor mattmoor left review comments

@dgerd dgerd dgerd left review comments

@vaikas vaikas Awaiting requested review from vaikas

Assignees

@mattmoor mattmoor

@evankanderson evankanderson

@dgerd dgerd

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dprotaso @dgerd @knative-prow-robot @mattmoor @googlebot @evankanderson