Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Queue ReadinessProbe Kubelet Header e2e Test #4667

Merged
merged 1 commit into from
Jul 10, 2019

Conversation

joshrider
Copy link
Contributor

- e2e test verifies that readiness probe receives kube-probe header

Co-authored-by: Joshua Rider jrider@pivotal.io

Supports #4649

Proposed Changes

  • changes the /_healthz endpoint of the runtime test image to /healthz.
  • changes /healthz path of runtime test image to return HTTP Status 400 if kubelet's User-Agent headers are not present
  • adds an end-to-end test with a ReadinessProbe hitting runtime's /healthz path to verify the queue-proxy's addition of kubelet's User-Agent header

Release Note

NONE

@knative-prow-robot knative-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 9, 2019
Copy link
Contributor

@knative-prow-robot knative-prow-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joshrider: 0 warnings.

In response to this:

  • e2e test verifies that readiness probe receives kube-probe header

Co-authored-by: Joshua Rider jrider@pivotal.io

Supports #4649

Proposed Changes

  • changes the /_healthz endpoint of the runtime test image to /healthz.
  • changes /healthz path of runtime test image to return HTTP Status 400 if kubelet's User-Agent headers are not present
  • adds an end-to-end test with a ReadinessProbe hitting runtime's /healthz path to verify the queue-proxy's addition of kubelet's User-Agent header

Release Note

NONE

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added the area/test-and-release It flags unit/e2e/conformance/perf test issues for product features label Jul 9, 2019
@shashwathi
Copy link
Contributor

/assign @mattmoor

Copy link
Member

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nit about placement otherwise LGTM. thanks!

test/e2e/readiness_probe_test.go Outdated Show resolved Hide resolved
    - e2e test verifies that readiness probe receives kube-probe header

Co-authored-by: Shash Reddy <shashwathireddy@gmail.com>
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no Indicates the PR's author has not signed the CLA. label Jul 9, 2019
@shashwathi
Copy link
Contributor

@mattmoor : Moved the file to conformance package. Ready for another review 👍

@shashwathi
Copy link
Contributor

/test pull-knative-serving-integration-tests

Copy link
Member

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 10, 2019
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joshrider, mattmoor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 10, 2019
@mattmoor mattmoor added cla: yes Indicates the PR's author has signed the CLA. and removed cla: no Indicates the PR's author has not signed the CLA. labels Jul 10, 2019
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@knative-prow-robot knative-prow-robot merged commit f51c54c into knative:master Jul 10, 2019
@joshrider joshrider deleted the probe-e2e branch August 6, 2019 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release It flags unit/e2e/conformance/perf test issues for product features cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants