Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use user-defined readinessProbe in queue-proxy #4731

Merged
merged 9 commits into from Jul 16, 2019
Merged

Use user-defined readinessProbe in queue-proxy #4731

merged 9 commits into from Jul 16, 2019

Commits on Jul 16, 2019

  1. use user-defined readinessprobe in queue-proxy 

    Signed-off-by: Shash Reddy <shashwathireddy@gmail.com>
Co-authored-by: Shash Reddy <shashwathireddy@gmail.com>
    @joshrider @shashwathi
    joshrider and shashwathi committed Jul 16, 2019
    Copy the full SHA
    5f8ac75 View commit details
    Browse the repository at this point in the history

  2. validate probe handler count 

    Co-authored-by: Shash Reddy <shashwathireddy@gmail.com>
    @joshrider @shashwathi
    joshrider and shashwathi committed Jul 16, 2019
    Copy the full SHA
    b51d131 View commit details
    Browse the repository at this point in the history

  3. move guard to switch 

    Co-authored-by: Shash Reddy <shashwathireddy@gmail.com>
    @joshrider @shashwathi
    joshrider and shashwathi committed Jul 16, 2019
    Copy the full SHA
    d7ab18d View commit details
    Browse the repository at this point in the history

  4. remove unreachable branch

    @joshrider @shashwathi
    joshrider authored and shashwathi committed Jul 16, 2019
    Copy the full SHA
    08b12d9 View commit details
    Browse the repository at this point in the history

  5. Address comments 

    - merge logic for knative probes and user defined probes
- use probe-period as argument name
- pass probe as environment variable instead of container args

Signed-off-by: Shash Reddy <shashwathireddy@gmail.com>
    @joshrider @shashwathi
    joshrider authored and shashwathi committed Jul 16, 2019
    Copy the full SHA
    3f9dbe2 View commit details
    Browse the repository at this point in the history

  6. Address comments 

    - Use context for timeout
- do not override exec probe
- simplify the logic for errors when multiple probes are mentioned

Signed-off-by: Shash Reddy <shashwathireddy@gmail.com>
    @joshrider @shashwathi
    joshrider authored and shashwathi committed Jul 16, 2019
    Copy the full SHA
    7ab8681 View commit details
    Browse the repository at this point in the history

  7. use url.Parse in queue test 

    Co-authored-by: Shash Reddy <shashwathireddy@gmail.com>
    @joshrider @shashwathi
    joshrider and shashwathi committed Jul 16, 2019
    Copy the full SHA
    dc9663d View commit details
    Browse the repository at this point in the history

  8. use 'probe-period' as flag in queue binary 

    Co-authored-by: Shash Reddy <shashwathireddy@gmail.com>
    @joshrider @shashwathi
    joshrider and shashwathi committed Jul 16, 2019
    Copy the full SHA
    63295fe View commit details
    Browse the repository at this point in the history

  9. Add comment for using pollImmediateUntil instead of pollImmediate 

    Signed-off-by: Shash Reddy <shashwathireddy@gmail.com>
    @joshrider @shashwathi
    joshrider authored and shashwathi committed Jul 16, 2019
    Copy the full SHA
    8eaf076 View commit details
    Browse the repository at this point in the history