-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deploy the HPA autoscaler as a separate controller. #4990
Deploy the HPA autoscaler as a separate controller. #4990
Conversation
This has been fairly long in the making. The HPA controller can now act as a reference implementation for a custom autoscaler based on the metrics that the Knative autoscaling system collects and exposes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@markusthoemmes: 0 warnings.
In response to this:
Proposed Changes
This has been fairly long in the making. The HPA controller can now act as a reference implementation for a custom autoscaler based on the metrics that the Knative autoscaling system collects and exposes.
Release Note
The HPA autoscaler now runs in its own container.
/assign @vagababov @mattmoor
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/assign @mattmoor
limits: | ||
cpu: 1000m | ||
memory: 1000Mi | ||
ports: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we actually report anything?
I guess controller core might...
@mattmoor your wish has been granted 😁 |
/test pull-knative-serving-integration-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: markusthoemmes, mattmoor, vagababov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Proposed Changes
This has been fairly long in the making. The HPA controller can now act as a reference implementation for a custom autoscaler based on the metrics that the Knative autoscaling system collects and exposes.
Release Note
/assign @vagababov @mattmoor