Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy the HPA autoscaler as a separate controller. #4990

Merged
merged 2 commits into from
Jul 31, 2019

Conversation

markusthoemmes
Copy link
Contributor

Proposed Changes

This has been fairly long in the making. The HPA controller can now act as a reference implementation for a custom autoscaler based on the metrics that the Knative autoscaling system collects and exposes.

Release Note

The HPA autoscaler now runs in its own container.

/assign @vagababov @mattmoor

This has been fairly long in the making. The HPA controller can now act as a reference implementation for a custom autoscaler based on the metrics that the Knative autoscaling system collects and exposes.
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jul 30, 2019
@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 30, 2019
Copy link
Contributor

@knative-prow-robot knative-prow-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@markusthoemmes: 0 warnings.

In response to this:

Proposed Changes

This has been fairly long in the making. The HPA controller can now act as a reference implementation for a custom autoscaler based on the metrics that the Knative autoscaling system collects and exposes.

Release Note

The HPA autoscaler now runs in its own container.

/assign @vagababov @mattmoor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

@vagababov vagababov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

/assign @mattmoor

limits:
cpu: 1000m
memory: 1000Mi
ports:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we actually report anything?
I guess controller core might...

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 30, 2019
@knative-prow-robot knative-prow-robot removed the lgtm Indicates that a PR is ready to be merged. label Jul 31, 2019
@markusthoemmes
Copy link
Contributor Author

@mattmoor your wish has been granted 😁

@markusthoemmes
Copy link
Contributor Author

/test pull-knative-serving-integration-tests

Copy link
Member

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 31, 2019
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markusthoemmes, mattmoor, vagababov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 31, 2019
@knative-prow-robot knative-prow-robot merged commit 3a6f8ee into knative:master Jul 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/autoscale cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants