Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always pass Healthy dests to the throttler #5466

Merged
merged 1 commit into from
Sep 10, 2019

Commits on Sep 10, 2019

  1. Always pass Healthy dests to the throttler

    TL;DR: This is needed for future "ideal" load balancing in throttler wherein I
    will need the actual pods to send traffic to -- so always send the ready
    pod IPs. But this doubles as `ReadyPodCount`, so remove that.
    
    As discussed with Greg, but for posterity:
    
    Right now we know everything that is in dests is healthy. So when we switch to clusterIP
    we can forward all the pods there for endpoints count reasons.
    
    In future when we will have both healthy and unhealthy pods passed into the
    we can combine and probe that combined list and send all the healthy ones to the throttler as we do now.
    
    In any case backendCount==|dests|.
    
    In theory we might probe unready addresses even when we're using cluster IP since we're delegating loadbalancing decision to the throttler,
    but this might break the capacity computations, since there might be more pods to use than cluster IP can reach, so this might not be
    a good initial approach, but a future enhancement.
    
    /assign @greghaynes @markusthoemmes mattmoor
    vagababov committed Sep 10, 2019
    Configuration menu
    Copy the full SHA
    3124a38 View commit details
    Browse the repository at this point in the history