Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark LoadBalancerReady False when VirtualService failed to be reconciled #6048

Merged
merged 3 commits into from Nov 26, 2019
Merged

Mark LoadBalancerReady False when VirtualService failed to be reconciled #6048

merged 3 commits into from Nov 26, 2019

Conversation

nak3
Copy link
Contributor

@nak3 nak3 commented Nov 16, 2019 •
edited

Proposed Changes

Currently LoadBalancerReady is not updated even when VirtualService failed to be reconciled.

This patch updates LoadBalancerReady with reason and message by using
returned error message.

Also, MarkLoadBalancerPending() is changed to MarkLoadBalancerNotReady()
by following #5076.

/lint

Release Note

NONE

AFTER THIS PATCH:

status:
  conditions:
  - lastTransitionTime: "2019-11-16T11:41:46Z"
    message: 'failed to create VirtualService: admission webhook "pilot.validation.istio.io"
      denied the request: configuration is invalid: regex match ''^service-to-service-call-via-activator-both-disabled-vktmmxev\.serving-tests(\.svc(\.cluster\.local)?)?(?::\d{1,5})?$''
      cannot be greater than 100 bytes'
    reason: ReconcileVirtualServiceFailed
    status: "False"
    type: LoadBalancerReady
  - lastTransitionTime: "2019-11-16T11:08:23Z"
    status: Unknown
    type: NetworkConfigured
  - lastTransitionTime: "2019-11-16T11:41:46Z"
    message: Ingress reconciliation failed
    reason: ReconcileIngressFailed
    status: "False"
    type: Ready

@nak3
Mark LoadBalancerReady false when VirtualService failed to be reconciled
f1102ec 
Currently LoadBalancerReady is not updated even when VirtualService failed to be reconciled.

This patch updated LoadBalancerReady with the reason and message by using
returned error.
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Nov 16, 2019
@knative-prow-robot knative-prow-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 16, 2019
knative-prow-robot
knative-prow-robot reviewed Nov 16, 2019
View reviewed changes
Copy link
Contributor

@knative-prow-robot knative-prow-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nak3: 1 warning.

In response to this:

Proposed Changes

Currently LoadBalancerReady is not updated even when VirtualService failed to be reconciled.

This patch updates LoadBalancerReady with reason and message by using
returned error message.

Also, MarkLoadBalancerPending() is changed to MarkLoadBalancerNotReady()
by following #5076.

/lint

Release Note

NONE

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

pkg/apis/networking/v1alpha1/ingress_lifecycle.go Outdated Show resolved Hide resolved
@knative-prow-robot knative-prow-robot added area/API API objects and controllers area/networking labels Nov 16, 2019
@nak3
Copy link
Contributor Author

nak3 commented Nov 18, 2019

/cc @JRBANCEL

@nak3 nak3 mentioned this pull request Nov 18, 2019
Closed
savitaashture
savitaashture reviewed Nov 18, 2019
View reviewed changes
pkg/apis/networking/v1alpha1/ingress_lifecycle.go Outdated
@@ -73,11 +77,16 @@ func (is *IngressStatus) MarkLoadBalancerReady(lbs []LoadBalancerIngressStatus,

// MarkLoadBalancerPending marks the "IngressConditionLoadBalancerReady" condition to unknown to
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// MarkLoadBalancerPending marks the "IngressConditionLoadBalancerReady" condition to unknown to
// MarkLoadBalancerNotReady marks the "IngressConditionLoadBalancerReady" condition to unknown to

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to make status as NotReady or Unknown?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the review.

Do we need to make status as NotReady or Unknown?

You mean that it is strange as MarkLoadBalancerNotReady() marks Unknown, correct? I thought so first, but as per #5076 (comment),

MarkFooNotReady -> Ready=Unknown

is the most prevalent for now.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean that it is strange as MarkLoadBalancerNotReady() marks Unknown, correct? I thought so first, but as per #5076 (comment),

MarkFooNotReady -> Ready=Unknown

is the most prevalent for now.

Yes felt strange.

Thank you i dint see #5076 (comment)

@knative-prow-robot knative-prow-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 18, 2019
@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-serving-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/ingress/ingress.go 85.4% 84.9% -0.5

@JRBANCEL
Copy link
Contributor

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 18, 2019
@tcnghia
Copy link
Contributor

tcnghia commented Nov 26, 2019

/approve

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nak3, tcnghia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 26, 2019
@knative-prow-robot knative-prow-robot merged commit a1e567f into knative:master Nov 26, 2019
@tcnghia tcnghia mentioned this pull request May 4, 2020
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@savitaashture savitaashture savitaashture left review comments

@knative-prow-robot knative-prow-robot knative-prow-robot left review comments

@tcnghia tcnghia Awaiting requested review from tcnghia

@yanweiguo yanweiguo Awaiting requested review from yanweiguo

@JRBANCEL JRBANCEL Awaiting requested review from JRBANCEL

Assignees

@JRBANCEL JRBANCEL

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/API API objects and controllers area/networking cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@nak3 @knative-metrics-robot @JRBANCEL @tcnghia @knative-prow-robot @savitaashture @googlebot